Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ohmienvelope wiggler mask #828

Closed
wants to merge 2 commits into from
Closed

Conversation

oscarxblanco
Copy link
Contributor

This PR solves issue #825 .
The wiggler indexes and radiation element indexes are intersected. Common elements, if any, are removed from the radiation element list.
This is done in order to keep indexes compatible with the separation of the diffusion matrix calculation for the wigglers.

Additionally, help is modified and non-strict check_6d is included.

I also found out that the atmexall was not compiling FDW.c. I added it.

o

@oscarxblanco oscarxblanco added bug Matlab For Matlab/Octave AT code labels Sep 4, 2024
@oscarxblanco
Copy link
Contributor Author

Dear @swhite2401 and @lfarv ,
I have included FDW.c in atmexall.m . It seems to have issues in macos-13. Do you know what could be happening ?

@lfarv
Copy link
Contributor

lfarv commented Sep 4, 2024

As I mentioned here, there seems to be no problem with indexes.
Concerning FDW.c and ohmienvelope, this is corrected in #822, which supersedes this PR.

@oscarxblanco: I suggest that you rather look at #822 (I add you to the reviewers). You'll see by the way that radindex is now useless.

@oscarxblanco oscarxblanco deleted the fix_ohmienvelope_wig_mask branch September 4, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Matlab For Matlab/Octave AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants