Unescape encoded Ascii85 payload before decoding #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brief testing shows that when the encoded Ascii85 payload passes through the Nagios XI (JSON) API that the backslash character is escaped. Instead of handling this client-side we extend the decoding process to automatically handle unescaping that pattern. This also provides a "hook" for further unescaping if other monitoring systems apply similar escaping of the encoded payload. Also, fix various typos in doc comments not caught during previous polishing passes. refs GH-251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief testing shows that when the encoded Ascii85 payload passes through the Nagios XI (JSON) API that the backslash character is escaped. Instead of handling this client-side we extend the decoding process to automatically handle unescaping that pattern. This also provides a "hook" for further unescaping if other monitoring systems apply similar escaping of the encoded payload.
Also, fix various typos in doc comments not caught during previous polishing passes.
refs GH-251