Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method for growing errors collection with deduplication behavior #214

Closed
atc0005 opened this issue Jun 23, 2023 · 0 comments · Fixed by #215
Closed

Add method for growing errors collection with deduplication behavior #214

atc0005 opened this issue Jun 23, 2023 · 0 comments · Fixed by #215
Assignees
@atc0005
Labels
enhancement New feature or request errors
Milestone
v0.16.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 23, 2023

In contrast to the (nagios.Plugin).AddError method which does not perform deduplication, add a new method which does.
@atc0005 atc0005 added the enhancement New feature or request label Jun 23, 2023
@atc0005 atc0005 added this to the v0.16.0 milestone Jun 23, 2023
@atc0005 atc0005 self-assigned this Jun 23, 2023
atc0005 added a commit that referenced this issue Jun 23, 2023
@atc0005
Provide Plugin.AddUniqueError with dedupe behavior
27c3023 
In contrast to Plugin.AddError which does not provide
deduplication of errors before growing the collection, the
Plugin.AddUniqueError method *does* provide deduplication.

The dedupe behavior is provided by case-insensitive
comparison of the error string for the provided error against
existing errors already in the collection.

refs GH-214
@atc0005 atc0005 mentioned this issue Jun 23, 2023
Merged
@atc0005 atc0005 added the errors label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request errors
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

Provide Plugin.AddUniqueError with dedupe behavior atc0005/go-nagios
1 participant
@atc0005