Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for overriding section headers/labels #107

Closed
atc0005 opened this issue Dec 20, 2021 · 0 comments · Fixed by #119 or #123
Closed

Add support for overriding section headers/labels #107

atc0005 opened this issue Dec 20, 2021 · 0 comments · Fixed by #119 or #123
Assignees
@atc0005
Labels
enhancement New feature or request output/plugin plugin output intended for monitoring system ingest
Milestone
v0.9.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Dec 20, 2021 •
edited
Loading

As an example, the section header/label for service check thresholds is a hard-coded "THRESHOLDS" text string.

In the strictest sense, thresholds should be crossed before a service state changes, not just met.

In some cases, you may not want to focus on a threshold being crossed, but rather a specific external status being reached.

For example, if you're monitoring a remote web server you may wish to indicate in Long Service Output that receiving a 5xx server response code will result in a CRITICAL service check state, not crossing a threshold of a 5xx server response code.

To support those use cases (and many others), each section header/label should allow client code to specify what text values to use.
@atc0005 atc0005 added the enhancement New feature or request label Dec 20, 2021
@atc0005 atc0005 added this to the Future milestone Dec 20, 2021
@atc0005 atc0005 self-assigned this Dec 20, 2021
@atc0005 atc0005 mentioned this issue Jun 14, 2022
Closed
@atc0005 atc0005 modified the milestones: Future, Next Release Jun 15, 2022
@atc0005 atc0005 added the output/plugin plugin output intended for monitoring system ingest label Jun 15, 2022
@atc0005 atc0005 changed the title Add option to override "THRESHOLDS" label Add option to override section headers/labels Jun 15, 2022
@atc0005 atc0005 changed the title Add option to override section headers/labels Add support for overriding section headers/labels Jun 15, 2022
atc0005 added a commit that referenced this issue Jun 15, 2022
@atc0005
Add support for overridding section headers/labels
95eef2e 
Exported functionality:

- add exported methods to set label text for Thresholds,
  Errors and Detailed Info sections

Unexported/helper functionality:

- add unexported fields to track client code choices
- add helper methods to provide client code choices or
  default values

refs GH-107
atc0005 added a commit that referenced this issue Jun 15, 2022
@atc0005
Add support for overridding section headers/labels
0669aa0 
Exported functionality:

- add exported methods to set label text for Thresholds,
  Errors and Detailed Info sections

Unexported/helper functionality:

- add unexported fields to track client code choices
- add helper methods to provide client code choices or
  default values

refs GH-107
@atc0005 atc0005 mentioned this issue Jun 15, 2022
Merged
atc0005 added a commit that referenced this issue Jun 15, 2022
@atc0005
Add support for overridding section headers/labels
68b1290 
Exported functionality:

- add exported methods to set label text for Thresholds,
  Errors and Detailed Info sections

Unexported/helper functionality:

- add unexported fields to track client code choices
- add helper methods to provide client code choices or
  default values

refs GH-107
atc0005 added a commit that referenced this issue Jun 15, 2022
@atc0005
Fix incorrect interpolation order for labels
11c1af6 
Commit f0c9c49 applied an
incorrect interpolation order for the (potentially custom)
section header/label values.

This commit updates the order so that the label text is placed
within the formatting characters as intended.

refs GH-107
refs GH-119
@atc0005 atc0005 mentioned this issue Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request output/plugin plugin output intended for monitoring system ingest
Projects
None yet
Milestone
v0.9.0
1 participant
@atc0005