Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staticcheck to v0.5.1 #1694

Merged
merged 1 commit into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,17 @@ others.
Unless indicated otherwise, the following linting tools are included in the
`go-ci-stable`, `go-ci-oldstable` and `go-ci-unstable` images:

| Linter | Version |
| --------------------------------------------------------------------- | ------------------------------------------------------- |
| [`staticcheck`](https://github.com/dominikh/go-tools) | `2023.1.7` (`v0.4.7`) (`stable` and `oldstable` images) |
| [`staticcheck`](https://github.com/dominikh/go-tools) | `2024.1rc1` (`v0.5.0-rc.1`) (`unstable` image) |
| [`golangci-lint`](https://github.com/golangci/golangci-lint) | `v1.60.1` |
| [`govulncheck`](https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck) | `v1.1.3` |
| [`deadcode`](https://pkg.go.dev/golang.org/x/tools/cmd/deadcode) | `v0.24.0` |
| [`orijtech/httperroryzer`](https://github.com/orijtech/httperroryzer) | `v0.0.1` (`oldstable` image) |
| [`orijtech/structslop`](https://github.com/orijtech/structslop) | `v0.0.8` (`oldstable` image) |
| [`orijtech/tickeryzer`](https://github.com/orijtech/tickeryzer) | `v0.0.3` (`oldstable` image) |
| [`pelletier/go-toml`](https://github.com/pelletier/go-toml) | `v2.2.2` |
| [`fatih/errwrap`](https://github.com/fatih/errwrap) | `v1.6.0` |
| Linter | Version |
| --------------------------------------------------------------------- | ---------------------------- |
| [`staticcheck`](https://github.com/dominikh/go-tools) | `2024.1.1` (`v0.5.1`) |
| [`golangci-lint`](https://github.com/golangci/golangci-lint) | `v1.60.1` |
| [`govulncheck`](https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck) | `v1.1.3` |
| [`deadcode`](https://pkg.go.dev/golang.org/x/tools/cmd/deadcode) | `v0.24.0` |
| [`orijtech/httperroryzer`](https://github.com/orijtech/httperroryzer) | `v0.0.1` (`oldstable` image) |
| [`orijtech/structslop`](https://github.com/orijtech/structslop) | `v0.0.8` (`oldstable` image) |
| [`orijtech/tickeryzer`](https://github.com/orijtech/tickeryzer) | `v0.0.3` (`oldstable` image) |
| [`pelletier/go-toml`](https://github.com/pelletier/go-toml) | `v2.2.2` |
| [`fatih/errwrap`](https://github.com/fatih/errwrap) | `v1.6.0` |

Forks:

Expand Down
4 changes: 2 additions & 2 deletions oldstable/combined/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ FROM amd64/golang:1.22.6-bookworm as builder
ENV GOTOOLCHAIN="local"

ENV GOLANGCI_LINT_VERSION="v1.60.1"
ENV STATICCHECK_VERSION="v0.4.7"
ENV STATICCHECK_VERSION="v0.5.1"
ENV DEADCODE_VERSION="v0.24.0"
ENV GOVULNCHECK_VERSION="v1.1.3"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
Expand Down Expand Up @@ -129,7 +129,7 @@ LABEL org.opencontainers.image.authors="Adam Chalkley (github.com/atc0005)"
ENV GOTOOLCHAIN="local"

ENV GOLANGCI_LINT_VERSION="v1.60.1"
ENV STATICCHECK_VERSION="v0.4.7"
ENV STATICCHECK_VERSION="v0.5.1"
ENV DEADCODE_VERSION="v0.24.0"
ENV GOVULNCHECK_VERSION="v1.1.3"
ENV TOMLL_VERSION="v2.2.2"
Expand Down
4 changes: 2 additions & 2 deletions stable/combined/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ FROM amd64/golang:1.23.0-bookworm as builder
ENV GOTOOLCHAIN="local"

ENV GOLANGCI_LINT_VERSION="v1.60.1"
ENV STATICCHECK_VERSION="v0.4.7"
ENV STATICCHECK_VERSION="v0.5.1"
ENV DEADCODE_VERSION="v0.24.0"
ENV GOVULNCHECK_VERSION="v1.1.3"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
Expand Down Expand Up @@ -135,7 +135,7 @@ ENV STRUCTSLOP_VERSION="33c868804e9e6070fdaee64b729d3129bbe85a53"
ENV TICKERYZER_VERSION="b38acaa6d76d30629a49ad9eddd1aa5ddd0afa8f"

ENV GOLANGCI_LINT_VERSION="v1.60.1"
ENV STATICCHECK_VERSION="v0.4.7"
ENV STATICCHECK_VERSION="v0.5.1"
ENV DEADCODE_VERSION="v0.24.0"
ENV GOVULNCHECK_VERSION="v1.1.3"
# ENV HTTPERRORYZER_VERSION="v0.0.1"
Expand Down
6 changes: 2 additions & 4 deletions unstable/combined/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ ENV GOLANGCI_LINT_VERSION="v1.60.1"

# A current master branch build is used for pre-release Go versions, otherwise
# the latest upstream build of the tool is installed in this image.
# ENV STATICCHECK_VERSION="v0.4.7"
# ENV STATICCHECK_VERSION="dec278f2f0d94b07c04db075d807e9f499f5d7b5"
ENV STATICCHECK_VERSION="v0.5.0-rc.1"
ENV STATICCHECK_VERSION="v0.5.1"

ENV DEADCODE_VERSION="v0.24.0"
ENV GOVULNCHECK_VERSION="v1.1.3"
Expand Down Expand Up @@ -145,9 +144,8 @@ ENV GOTOOLCHAIN="local"
# Latest upstream
ENV GOLANGCI_LINT_VERSION="v1.60.1"

# ENV STATICCHECK_VERSION="v0.4.7"
# ENV STATICCHECK_VERSION="dec278f2f0d94b07c04db075d807e9f499f5d7b5"
ENV STATICCHECK_VERSION="v0.5.0-rc.1"
ENV STATICCHECK_VERSION="v0.5.1"

# These commits/versions are provided by temporary forks of the upstream
# projects. The plan is to switch back to current upstream vesions once
Expand Down