Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goconst linting errors #996

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix goconst linting errors #996

merged 2 commits into from
Nov 2, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Nov 2, 2023

Changes

  • Use nolint directive for Name format string
  • Fix goconst linting error for shorthand suffix

@atc0005
Use nolint directive for Name format string
48ac6ef 
Exclude the '* Name: %s%s' pattern used to generate plugin
output from the goconst linter. This is a hotfix for a
later refactoring goal.
@atc0005
Fix goconst linting error for shorthand suffix
1b426cf 
Replace literal text with new `shorthandFlagSuffix` config
constant.
@atc0005 atc0005 added bug Something isn't working config linting labels Nov 2, 2023
@atc0005 atc0005 added this to the v0.36.2 milestone Nov 2, 2023
@atc0005 atc0005 self-assigned this Nov 2, 2023
@atc0005 atc0005 merged commit f6642b4 into master Nov 2, 2023
26 of 30 checks passed
@atc0005 atc0005 deleted the fix-goconst-linting-errors branch November 2, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
bug Something isn't working config linting
Projects
None yet
Milestone
v0.36.2
Development

Successfully merging this pull request may close these issues.
1 participant
@atc0005