Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build tags for Go 1.17 compatibility #87

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Sep 10, 2021

golangci-lint v1.42.1 introduced changes to the gofmt linter.
These changes appear to match the same ones introduced with
Go 1.17 which expect build tags to be in a specific format
OR include an additional leading set of build tags with
the //go: prefix.

This commit adds this additional build tag entry to both
os-specific variants of the validate-*.go file.

@atc0005 atc0005 added bug Something isn't working builds linting labels Sep 10, 2021
@atc0005 atc0005 added this to the Next Release milestone Sep 10, 2021
@atc0005 atc0005 self-assigned this Sep 10, 2021
@atc0005 atc0005 force-pushed the update-build-tags-for-go117-gofmt-compatibility branch from 7512539 to ed2da03 Compare September 10, 2021 20:50
golangci-lint v1.42.1 introduced changes to the `gofmt` linter.
These changes appear to match the same ones introduced with
Go 1.17 which expect build tags to be in a specific format
OR include an additional leading set of build tags with
the `//go:` prefix.

This commit adds this additional build tag entry to all
os-specific variants of applicable files.
@atc0005 atc0005 force-pushed the update-build-tags-for-go117-gofmt-compatibility branch from ed2da03 to 6c72db6 Compare September 10, 2021 20:53
@atc0005 atc0005 merged commit b609182 into master Sep 10, 2021
@atc0005 atc0005 deleted the update-build-tags-for-go117-gofmt-compatibility branch September 10, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builds linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant