Add ValidationStatus to CertChainValidationResult #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the CertChainValidationResult interface to require an implementation of ValidationStatus method. Add/Update implementation for each of: - ExpirationValidationResult - SANsListValidationResult - HostnameValidationResult Update the ExpirationValidationResult implementation to use existing helper methods to determine validation status instead of repeating expiration checks. Add `ValidationStatus*` keyword constants for use with all CertChainValidationResult implementations.
atc0005
deleted the
extend-certchainvalidationresult-to-include-validationstatus-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the CertChainValidationResult interface to require an implementation of ValidationStatus method.
Add/Update implementation for each of:
Update the ExpirationValidationResult implementation to use existing helper methods to determine validation status instead of repeating expiration checks.
Add
ValidationStatus*keyword constants for use with all CertChainValidationResult implementations.