Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebOne adds dummy content-type if server returns 304 (Not Modified) #119

Closed
mgroeber9110 opened this issue Mar 24, 2024 · 0 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mgroeber9110
Copy link

mgroeber9110 commented Mar 24, 2024

Version: 0.16.3

When making a conditional HTTP request where the server responds with a 304 (Not Modified) code, WebOne inserts a Content-Type header with webone/unknown-content-type.

This appears to be at least against the spirit of RFC7232 which suggests not returning additional metadata. In the case of the browser of the FreeGEOS project, I found that this would lead to incorrect behavior because the mime type would override the one stored in the cache (which is probably in itself a bug...).

Example:

$ curl -I http://www.mgroeber.de --header 'If-None-Match: "1006-60d7ffbc456d8"' -x 192.168.178.21:8080
HTTP/1.1 304 Not Modified
Date: Sun, 24 Mar 2024 20:44:40 GMT
Server: Apache/2.4.56(Debian)
ETag: "1006-60d7ffbc456d8"
Accept-Ranges: bytes
Last-Modified: Wed, 27 Dec 2023 16:06:36 GMT
Via: HTTP/1.0 WebOne/0.16.3.0
Content-Type: webone/unknown-content-type
Proxy-Connection: keep-alive
Connection: Keep-Alive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants