-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallel mode broken in Linux #44
Comments
Hm, that one might be difficult to debug for me... I'll see what I can do about it. |
I got around to bisecting this, it looks like the bad commit is eef6466 (but actually I tested 5cbd52e, since it's needed to compile, but I assume the problem is in eef6466 ) I had to remove the "build" folder in between testing commits or else my bisecting would get messed up (it would work when it shouldn't etc...) Anyway so basically d1cb99f is the last commit that worked for me |
In my case the application freezes is random in the start, I can't reproduce it with 100% certain. |
As far as I can tell, the renderer itself is fine, since the retracer runs stable and fast with parallel rendering enabled on my Ubuntu VM. I'll need to check the M64P plugin interface next. |
Oh, never mind my previous reply, I forgot to run the retracer with the |
I can still reproduce this problem, 1/30 attempts. Is very random. |
Haven't been able to reproduce so far. But I'll reopen it in case anyone else knows more. |
I haven't had any issues since you closed this |
Since m_task was initialized after threads are created, there's a small time window where workers could encounter an uninitialized m_task. Possible complementary fix for #44
I have found two more (silly) mistakes that could have been responsible for the crashes and some abnormalities caused by d52d94f. |
Can this be closed then? Seems stable to me |
Yeah, I hope it is now. |
Finally, I can no longer reproduce this issue. |
In Windows, selecting the "Parallel" option works (mupen64plus). In Linux, the application freezes and must be force closed.
The text was updated successfully, but these errors were encountered: