Resolves #18 - fix pagination for absence and attencence lists

at-gmbh · Mar 29, 2021 · caccf0b · caccf0b
1 parent 8e92839
commit caccf0b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/personio_py/client.py b/src/personio_py/client.py
@@ -161,7 +161,7 @@ def request_paginated(
         if params is None:
             params = {}
         params['limit'] = limit
-        params['offset'] = 0
+        params['offset'] = 1
         # continue making requests until no more data is returned
         data_acc = []
         while True:
@@ -172,7 +172,7 @@ def request_paginated(
                 if response['metadata']['current_page'] == response['metadata']['total_pages']:
                     break
                 else:
-                    params['offset'] += len(resp_data)
+                    params['offset'] += 1
             else:
                 break
         # return the accumulated data

diff --git a/tests/test_mock_api.py b/tests/test_mock_api.py
@@ -97,10 +97,10 @@ def test_auth_rotation_fail():
 def test_get_attendance():
     # mock the get absences endpoint (with different array offsets)
     responses.add(
-        responses.GET, re.compile('https://api.personio.de/v1/company/attendances?.*offset=0.*'),
+        responses.GET, re.compile('https://api.personio.de/v1/company/attendances?.*offset=1.*'),
         status=200, json=json_dict_attendance_rms, adding_headers={'Authorization': 'Bearer foo'})
     responses.add(
-        responses.GET, re.compile('https://api.personio.de/v1/company/attendances?.*offset=3.*'),
+        responses.GET, re.compile('https://api.personio.de/v1/company/attendances?.*offset=2.*'),
         status=200, json=json_dict_empty_response, adding_headers={'Authorization': 'Bearer bar'})
     # configure personio & get absences for alan
     personio = mock_personio()

diff --git a/tests/test_mock_api_absences.py b/tests/test_mock_api_absences.py
@@ -159,27 +159,27 @@ def mock_absence_types():
 def mock_absences():
     # mock the get absences endpoint (with different array offsets)
     responses.add(
-        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=0.*'),
+        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=1.*'),
         status=200, json=json_dict_absence_alan, adding_headers={'Authorization': 'Bearer foo'})
     responses.add(
-        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=3.*'),
+        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=2.*'),
         status=200, json=json_dict_empty_response, adding_headers={'Authorization': 'Bearer bar'})
 
 
 def mock_single_absences():
     # mock the get absences endpoint (with different array offsets)
     responses.add(
-        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=0.*'),
+        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=1.*'),
         status=200, json=json_dict_absence_alan_first, adding_headers={'Authorization': 'Bearer foo'})
     responses.add(
-        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=1.*'),
+        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=2.*'),
         status=200, json=json_dict_empty_response, adding_headers={'Authorization': 'Bearer bar'})
 
 
 def mock_no_absences():
     # mock the get absences endpoint
     responses.add(
-        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=0.*'),
+        responses.GET, re.compile('https://api.personio.de/v1/company/time-offs?.*offset=1.*'),
         status=200, json=json_dict_empty_response, adding_headers={'Authorization': 'Bearer bar'})