Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxRetryCount field to remote config #707

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

rgngl
Copy link
Contributor

@rgngl rgngl commented Aug 12, 2022

This way the EndpointWriter doesn't indefinitely try to connect to a non-existing host.

@c10h22
Copy link

c10h22 commented Aug 18, 2022

This fix is really needed as we don't want to retry indefinitely to connect to a host that goes offline.
We can make this better by implementing a custom MaxRetryCount by state.address a kind of callback function that returns an integer based on the parameter state.address

@nightwolfz
Copy link
Contributor

Very much needed.

@rogeralsing rogeralsing merged commit 1ee12e6 into asynkron:dev Oct 2, 2022
@rgngl rgngl deleted the fix/endpoint-writer-max-retry-count branch October 3, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants