chore: upgrade dependencies and fix metrics #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me. The only thing is that I don't really know why the envelope stuff was commented out so I don't know if it is safe to re-introduce it, probably @rogeralsing knows more about it |
Closed
|
@DamnWidget the envelope bits from the couchbase persistence you mean? those were in a broken state before due to the migration from gogo proto to real protobuf. Great job @Tochemey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #675
closes #674
closes #673
closes #670
closes #661
closes #662
closes #663
Note: Are we still using the travis build?
@rogeralsing @DamnWidget