Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to etcd/v3. #490

Merged
merged 8 commits into from
Aug 14, 2021
Merged

upgrade to etcd/v3. #490

merged 8 commits into from
Aug 14, 2021

Conversation

tutumagi
Copy link
Contributor

@tutumagi tutumagi commented May 17, 2021

upgrade to etcd/v3. So we donnot need to replace grpc package to the lower version.

@cupen
Copy link
Contributor

cupen commented May 19, 2021

It seems that etcd-v3.5 is coming soon.
etcd-io/etcd#12970

@tutumagi
Copy link
Contributor Author

It seems that etcd-v3.5 is coming soon.
etcd-io/etcd#12970

Yep, we can upgrade to the official 3.5 version later.

@cupen
Copy link
Contributor

cupen commented Jun 17, 2021

@tutumagi etcdv3.5 is released. Let's go! 💪
https://github.com/etcd-io/etcd/releases/tag/v3.5.0

@tutumagi
Copy link
Contributor Author

I will merge in next week.

@cupen
Copy link
Contributor

cupen commented Jun 22, 2021

I will merge in next week.

@tutumagi Hello, your pr is picked here. #494 Thanks for your work.

/cc @rogeralsing

@tutumagi
Copy link
Contributor Author

I have upgrade etcd to v3.5.0 on my fork branch. And what should I do next?

@cupen
Copy link
Contributor

cupen commented Jun 23, 2021

@tutumagi Run the example _examples/cluster-restartgracefully with etcd.
It also use gpc-v1.26 in go.mod. Just remove it like this pr ad09928

cd _examples/cluster-restartgracefully
make start-with-etcd

If every things is OK, you'll see some logs like:

2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-1" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-8" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-2" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-5" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-7" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-9" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-4" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-0" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-6" status="start" 
2021/06/23 11:15:56 INFO  [Example]     requests grainId="client-3" status="start" 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-8" status="end" loops=10000 take=1.337590244s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-1" status="end" loops=10000 take=1.337777042s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-9" status="end" loops=10000 take=1.432898883s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-5" status="end" loops=10000 take=1.432832689s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-0" status="end" loops=10000 take=1.436307804s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-4" status="end" loops=10000 take=1.513899654s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-2" status="end" loops=10000 take=1.515489662s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-7" status="end" loops=10000 take=1.51621749s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-3" status="end" loops=10000 take=1.516710336s 
2021/06/23 11:15:57 INFO  [Example]     requests grainId="client-6" status="end" loops=10000 take=1.517275484s 
2021/06/23 11:15:57 INFO  [Example]     end all. clients=10 total=100000 req/s=100000 take=1.517514248s 
2021/06/23 11:15:57 INFO  [Example]     countinue? (y/n)

Then renew all of the go.mod of examples.

cd _examples
make go.mod

BTW: I'll close my pr #494 if you want to finish yours.

@tutumagi
Copy link
Contributor Author

The merge done. And test _examples/cluster-restartgracefully works well.

@cupen
Copy link
Contributor

cupen commented Jul 30, 2021

@tutumagi I think we can use git rebase and git squash for reduce redundant commits.
https://www.git-tower.com/learn/git/faq/git-squash/

btw: This pr is useful. I'll merge it into my personal branch.
cc @rogeralsing

@cupen
Copy link
Contributor

cupen commented Jul 30, 2021

@tutumagi Oh, a month has passed, sorry for delay. And I hope you don't mind me talking a lot.

@rogeralsing
Copy link
Collaborator

What is the status on this one?

@cupen
Copy link
Contributor

cupen commented Aug 2, 2021

@rogeralsing

What is the status on this one?

Test OK on my branch. It's ready to merge.

@rogeralsing rogeralsing merged commit 73de6f2 into asynkron:dev Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants