Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial port #431

Merged
Merged

Conversation

umitkavala
Copy link
Contributor

@umitkavala umitkavala commented Nov 27, 2020

There are some changes happened on .net version since this issue created. I just want to make sure that I'm in correct path.
I've looked at MongoDb implementation : https://github.com/umitkavala/protoactor-dotnet/blob/09e5ec1cb99da6fb4f098415e8de2d877c3330f7/src/Proto.Cluster.Identity.MongoDb/MongoIdentityStorage.cs#L10
But we don't use IIdentityLookup interface there instead we use IdentityStorage.

What I understand is we need : https://github.com/umitkavala/protoactor-dotnet/blob/09e5ec1cb99da6fb4f098415e8de2d877c3330f7/src/Proto.Cluster.Identity/IIdentityStorage.cs#L7

Question is : are we going to port Proto.Cluster.Identity project? because when I look at Mongodb project we don't use any class from that.

If I try to port Proto.Cluster.Identity project, as you can see I've already stuck at

func (i *IdentityStorageLookup) Get(clusterIdentity *cluster.ClusterIdentity) *actor.PID {
	msg := newGetPid(clusterIdentity)
	i.system.Root.Request(i.router, msg)
}

because i.system.Root.Request doesn't return PID.

Could you please advise? IIdentityStorage + Proto.Cluster.Identity.MongoDb port?

@rogeralsing
Copy link
Collaborator

Question is : are we going to port Proto.Cluster.Identity project?

Yes i think we should.
Identity project is an abstraction which makes it possible to reuse a lot of the underlying code and the specific implementations can then just focus on the storage parts.

cc @mhelleborg for more context

Commit to check & validation of progress
@rogeralsing rogeralsing marked this pull request as ready for review April 30, 2021 06:52
@rogeralsing rogeralsing changed the base branch from dev to identity_lookup April 30, 2021 07:05
@rogeralsing rogeralsing merged commit 80db82e into asynkron:identity_lookup Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants