Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA cluster provider support for multiple images + pluggable member store #1980

Merged
merged 6 commits into from
May 2, 2023
Merged

ACA cluster provider support for multiple images + pluggable member store #1980

merged 6 commits into from
May 2, 2023

Conversation

sfmskywalker
Copy link
Contributor

Description

This PR refactors the ACA cluster provider with support for multiple Docker images hosted in the same ACA Managed Environment (the cluster).

The way the cluster provider works is as follows:

  1. When the provider is constructed, it reads ACA environment variables to get the ACA name, revision and replica name (host name).
  2. When the provider is requested to start as a member, it stores the cluster member details using a new abstraction called IClusterMemberStore. The default implementation leverages azure resource tags on the ACA resource, pretty much like what the AmazonECS cluster provider does.
  3. The provider starts a background task to periodically poll information from other members in the cluster to update the cluster topology. This, too, relies on the IClusterMemberStore to get all registered members. In the case of the default cluster member store implementation using tags, it basically queries all ACA resources belonging to the same ACA Managed Environment, concatenating all their tags, and constructing them into Member objects.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rogeralsing rogeralsing merged commit 1c69cc5 into asynkron:dev May 2, 2023
@sfmskywalker sfmskywalker deleted the aca-provider-memberstore branch May 2, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants