Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SQL mode NO_BACKSLASH_ESCAPES #268

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add support for SQL mode NO_BACKSLASH_ESCAPES #268

merged 1 commit into from
Apr 2, 2024

Conversation

mirromutth
Copy link
Contributor

Motivation:

Resolves #267

Modification:

  • ParamWriter skips backslash escaping if NO_BACKSLASH_ESCAPES is set
  • Load innodb_lock_wait_timeout without escaping

And unit tests and integration tests for NO_BACKSLASH_ESCAPES.

Result:

SQL mode NO_BACKSLASH_ESCAPES supported

@mirromutth mirromutth added the enhancement New feature or request label Mar 28, 2024
@mirromutth mirromutth added this to the 1.1.3 milestone Mar 28, 2024
@mirromutth mirromutth requested a review from jchrys March 28, 2024 06:07
@mirromutth mirromutth linked an issue Mar 28, 2024 that may be closed by this pull request
[feature] Support sql mode NO_BACKSLASH_ESCAPES #267
Closed
@mirromutth mirromutth marked this pull request as ready for review March 28, 2024 06:12
@mirromutth mirromutth force-pushed the 267-feature-support-sql-mode-no_backslash_escapes branch 2 times, most recently from a91656f to 8c24b1c Compare March 29, 2024 03:52
@mirromutth mirromutth force-pushed the 267-feature-support-sql-mode-no_backslash_escapes branch 2 times, most recently from 37c8c60 to 71491a9 Compare April 1, 2024 02:20
@mirromutth mirromutth force-pushed the 267-feature-support-sql-mode-no_backslash_escapes branch 2 times, most recently from 7dff016 to a2cd542 Compare April 2, 2024 02:12
@mirromutth mirromutth force-pushed the 267-feature-support-sql-mode-no_backslash_escapes branch from a2cd542 to 2cf45e2 Compare April 2, 2024 02:15
@mirromutth mirromutth requested a review from jchrys April 2, 2024 02:37
jchrys
jchrys approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@mirromutth mirromutth merged commit faa30a7 into trunk Apr 2, 2024
15 checks passed
@mirromutth mirromutth deleted the 267-feature-support-sql-mode-no_backslash_escapes branch April 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.3
Development

Successfully merging this pull request may close these issues.

[feature] Support sql mode NO_BACKSLASH_ESCAPES
2 participants
@mirromutth @jchrys