Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for decoding session state info #230

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add support for decoding session state info #230

merged 1 commit into from
Feb 13, 2024

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Feb 13, 2024 •
edited
Loading

Motivation:

Add support for SESSION_TRACK_SYSTEM_VARIABLES track info decoding

See also #227

Modification:

  • Make Capability.SESSION_TRACK available and disabled by default
  • Add SESSION_TRACK_SYSTEM_VARIABLES decoding in OkMessage

Result:

Session state information decoding support

@mirromutth mirromutth added the enhancement New feature or request label Feb 13, 2024
@mirromutth mirromutth linked an issue Feb 13, 2024 that may be closed by this pull request
[feature] Add support for decoding session state info in Ok packets #227
Closed
@mirromutth mirromutth force-pushed the 227-feature-add-support-for-decoding-session-state-info-in-ok-packets branch 2 times, most recently from 5d6b07d to 0103299 Compare February 13, 2024 03:13
jchrys
jchrys approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM.
just a nit

src/main/java/io/asyncer/r2dbc/mysql/message/server/OkMessage.java Show resolved Hide resolved
@mirromutth mirromutth force-pushed the 227-feature-add-support-for-decoding-session-state-info-in-ok-packets branch from 0103299 to 36b3a04 Compare February 13, 2024 04:43
@mirromutth mirromutth merged commit fbdd900 into trunk Feb 13, 2024
12 checks passed
@mirromutth mirromutth deleted the 227-feature-add-support-for-decoding-session-state-info-in-ok-packets branch February 13, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add support for decoding session state info in Ok packets
2 participants
@mirromutth @jchrys