Add support for compression protocol #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirromutth
force-pushed
the
216-feature-compression-support
branch
2 times, most recently
from
14ebe8e
to
8967db5
Compare
jchrys
reviewed
Feb 5, 2024
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionFactoryProvider.java
Show resolved
Hide resolved
jchrys
reviewed
Feb 7, 2024
mirromutth
force-pushed
the
216-feature-compression-support
branch
from
59f20da
to
0b8f17a
Compare
jchrys
requested changes
Feb 13, 2024
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionFactoryProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/io/asyncer/r2dbc/mysql/MySqlConnectionFactoryProvider.java
Outdated
Show resolved
Hide resolved
|
btw) |
- Refactor message codecs, move sequence ID handling to MessageDuplexCodec - Add compression codec and support for zstd and zlib - Add configuration options for compression algorithms and zstd compression level - Refactor the configuration way at `IntegrationTestSupport`
mirromutth
force-pushed
the
216-feature-compression-support
branch
from
0b8f17a
to
7ad491a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
See also #216 , MySQL Connect Options --compression-algorithms
Modification:
MessageDuplexCodecIntegrationTestSupportI refactored codec handlers, used the original Sequence ID concept instead of "Envelope ID", there are two main reasons for this:
QueryFlowshould not consider how the packet should be encoded, the "envelope ID" is obviously something that the encoding layer needs to considerLOCAL INFILE. TheQueryFlowneeds to constructingLocalInfileResponsewith an envelope ID, but this is obviously not any logic aboutLOCAL INFILEMessageDecoderto need to additionally consider whether to pass the envelope ID toServerMessageQueryFlow, allClientMessages and allServerMessages, which is bad.The reason why this concept was created in the early days was that the relationship of sequence IDs between packets was not complicated at that time, and it was reset to 0 every time in the command phase.
Result:
User can configure the compression algorithm to enable the MySQL compression protocol and the driver will auto select the preferred algorithm to use. The compression protocol is disabled by default.