Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lightweight ping syntax support #217

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add lightweight ping syntax support #217

merged 1 commit into from
Jan 25, 2024

Conversation

mirromutth
Copy link
Contributor

Motivation:

Add lightweight ping syntax support.

See also #214 .

Modification:

  • Add a PingStatement
  • Add default impl for MySqlStatement.returnGeneratedValues and MySqlStatement.fetchSize
  • Extract MySqlConnection.doPingInternal method for sending a MySQL ping

Result:

Any query starting with /* ping */ will be changed to perform a MySQL ping.

@mirromutth mirromutth added the enhancement New feature or request label Jan 25, 2024
@mirromutth mirromutth added this to the 1.1.0/0.10.0 milestone Jan 25, 2024
@mirromutth mirromutth linked an issue Jan 25, 2024 that may be closed by this pull request
[Feature] Support for Lightweight Ping Syntax #214
Closed
@mirromutth mirromutth marked this pull request as ready for review January 25, 2024 02:41
jchrys
jchrys approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirromutth mirromutth merged commit df0a358 into trunk Jan 25, 2024
12 checks passed
@mirromutth mirromutth deleted the 214-feature-support-for-lightweight-ping-syntax branch January 25, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

[Feature] Support for Lightweight Ping Syntax
2 participants
@mirromutth @jchrys