Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning Connection#setTransactionIsolationLevel Behavior with r2dbc-spi Specification #192

Closed
jchrys opened this issue Jan 11, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@jchrys
Copy link
Collaborator

jchrys commented Jan 11, 2024

Issue

The current implementation of Connection#setTransactionIsolationLevel does not align with its specification. According to the specification(), this method should configure the isolation level for the connection, and the specified isolation level should apply to all subsequent transactions. However, the current behavior applies the isolation level only to the next transaction.

Proposal

Aligning the behavior of Connection#setTransactionIsolationLevel with its specification. The implementation should be adjusted so that the configured isolation level persists for all subsequent transactions until explicitly changed.

Action Items

  • Modify the implementation of Connection#setTransactionIsolationLevel to align with the specification.(AbstractTransactionState could be utilized if needed )
  • Verify and update the transaction isolation behavior in the entire project to ensure consistency and adherence to the proposed changes.

Refs

@jchrys jchrys added enhancement New feature or request good first issue Good for newcomers labels Jan 11, 2024
@JohnNiang
Copy link
Contributor

I'm willing to contribute this enhancement.

/assign

@jchrys
Copy link
Collaborator Author

jchrys commented Jan 11, 2024

I'm willing to contribute this enhancement.

/assign

Thanks!

@jchrys jchrys added this to the 1.0.7/0.9.8 milestone Jan 11, 2024
jchrys pushed a commit that referenced this issue Jan 19, 2024
…tting (#202)

Motivation:

Aligning Connection#setTransactionIsolationLevel Behavior with r2dbc-spi
Specification. See #192
for more.

Modification:

Change session isolation level as well after invoking
`Connection#setTransactionIsolationLevel`.

Result:

All subsequent transactions will be applied the isolation level set by
`Connection#setTransactionIsolationLevel`.
@jchrys
Copy link
Collaborator Author

jchrys commented Jan 19, 2024

#202 resolved this issue

@jchrys jchrys closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants