-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added new /tools page #940
Conversation
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
…to tools-dashboard
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
…to tools-dashboard
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
@derberg can you please review the PR as majority of the UI and Filters are being completed. Certain UI fixes are remaining which will be completed soon. |
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
I know I'm no designer, but I wanted to leave a comment to compliment this page's design. I find it lovely and with a good UX. ✨ |
I second what @alequetzalli wrote. The difference is that #designismypassion and you know that once I say UI is great, it is great indeed 🤣 🤣 🤣 🤣 🤣 I'd only like to suggest one change that always comes to my mind when I see
wdyt? |
From my perspective, everything is ok because I just need to change a single line of text 😂. But definitely, we should ask @magicmatatjahu @alequetzalli regarding what's their view on these terms. They can give us more clarity over the terms we should use here. |
@akshatnema Please add separate between last select and button: When I click on |
I'm in favour of |
@magicmatatjahu @derberg A last query 😅, where should we include Tools Dashboard option in the Navbar? |
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
@derberg @magicmatatjahu all changes done, ready for review... |
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
IN A SHOCKING MOVE, ALEJANDRA AGREED WITH @derberg 😂 ya... Open Source and Commercial is more accurate ✌🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SOOOO PURRRTY 😍😍😍
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
eb73a88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!!! merging
@magicmatatjahu @alequetzalli the only change after your last approval was that I asked @akshatnema to "hide" this new view for now, so for now navigation still points to /docs/tools
.
Reason is that for now new tools view is pretty empty. In another PR @akshatnema will try to migrate table from /docs/tools
to /tools
and then we enable the view and set redirects (if needed - probably not) for old view
/rtm |
ooooooh I see... cool! that makes sense thanks for the extra context because I love learning and understanding changes happening |
Description
This PR adds a brand new page for the list of tools that give users to filter the tools according to their needs. Various filter parameters are given to filter the tools accordingly. This PR should be merged after the approval and merging of #939 so that linearly the data will be updated in the UI as well. Also, this PR will be drafted until UI of the page is not completed.
Related issue(s)
Resolves #383