Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new /tools page #940

Merged
merged 94 commits into from
Dec 22, 2022
Merged

Conversation

akshatnema
Copy link
Member

Description
This PR adds a brand new page for the list of tools that give users to filter the tools according to their needs. Various filter parameters are given to filter the tools accordingly. This PR should be merged after the approval and merging of #939 so that linearly the data will be updated in the UI as well. Also, this PR will be drafted until UI of the page is not completed.

Related issue(s)
Resolves #383

@netlify
Copy link

netlify bot commented Sep 11, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eb73a88
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63a47e2859635a0008560c83
😎 Deploy Preview https://deploy-preview-940--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@akshatnema
Copy link
Member Author

@derberg can you please review the PR as majority of the UI and Filters are being completed. Certain UI fixes are remaining which will be completed soon.

Copy link
Member

I know I'm no designer, but I wanted to leave a comment to compliment this page's design. I find it lovely and with a good UX. ✨

@derberg
Copy link
Member

derberg commented Dec 20, 2022

I second what @alequetzalli wrote. The difference is that #designismypassion and you know that once I say UI is great, it is great indeed 🤣 🤣 🤣 🤣 🤣

I'd only like to suggest one change that always comes to my mind when I see Free. My suggestion:

  • rename Free to Open-source or FOSS
  • rename Paid to Commercial

wdyt?

@akshatnema
Copy link
Member Author

wdyt?

From my perspective, everything is ok because I just need to change a single line of text 😂. But definitely, we should ask @magicmatatjahu @alequetzalli regarding what's their view on these terms. They can give us more clarity over the terms we should use here.

@magicmatatjahu
Copy link
Member

@akshatnema Please add separate between last select and button:

image

When I click on Filter button and then click outside, the dropdown should hide, but atm is still visible.

@magicmatatjahu
Copy link
Member

And last thing, border radius has bad colors 😄
image

@magicmatatjahu
Copy link
Member

I'm in favour of Open-source and Commercial

@akshatnema
Copy link
Member Author

@magicmatatjahu @derberg A last query 😅, where should we include Tools Dashboard option in the Navbar?

@magicmatatjahu
Copy link
Member

Change link for the Tools & Services

image

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
@akshatnema
Copy link
Member Author

@derberg @magicmatatjahu all changes done, ready for review...

akshatnema and others added 2 commits December 21, 2022 22:50
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
@quetzalliwrites
Copy link
Member

From my perspective, everything is ok because I just need to change a single line of text 😂. But definitely, we should ask @magicmatatjahu @alequetzalli regarding what's their view on these terms. They can give us more clarity over the terms we should use here.

IN A SHOCKING MOVE, ALEJANDRA AGREED WITH @derberg 😂

ya... Open Source and Commercial is more accurate ✌🏽

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOOOO PURRRTY 😍😍😍

magicmatatjahu
magicmatatjahu previously approved these changes Dec 22, 2022
akshatnema and others added 2 commits December 22, 2022 19:38
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!! merging

@magicmatatjahu @alequetzalli the only change after your last approval was that I asked @akshatnema to "hide" this new view for now, so for now navigation still points to /docs/tools.

Reason is that for now new tools view is pretty empty. In another PR @akshatnema will try to migrate table from /docs/tools to /tools and then we enable the view and set redirects (if needed - probably not) for old view

@derberg
Copy link
Member

derberg commented Dec 22, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 75f7cec into asyncapi:master Dec 22, 2022
@quetzalliwrites
Copy link
Member

Yay!!! merging

@magicmatatjahu @alequetzalli the only change after your last approval was that I asked @akshatnema to "hide" this new view for now, so for now navigation still points to /docs/tools.

Reason is that for now new tools view is pretty empty. In another PR @akshatnema will try to migrate table from /docs/tools to /tools and then we enable the view and set redirects (if needed - probably not) for old view

ooooooh I see... cool! that makes sense

thanks for the extra context because I love learning and understanding changes happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New page for /tools/
5 participants