Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Missy Turco and Akshat Nema as codeowners #890

Merged

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Jul 26, 2022

Description

As in title: add Missy Turco and Akshat Nema as codeowners.

These two people have contributed a lot to the development of this project and I think they should be codeowners of this repository. Anyone against this?

cc @derberg @fmvilas @alequetzalli @mcturco @akshatnema

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8056a9d
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/62e0f86b3df6d20007371996
😎 Deploy Preview https://deploy-preview-890--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@magicmatatjahu magicmatatjahu marked this pull request as ready for review July 26, 2022 13:43
@github-actions
Copy link

github-actions bot commented Jul 26, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 24
🟢 Accessibility 95
🟠 Best practices 83
🟢 SEO 90
🔴 PWA 30

Lighthouse ran on https://deploy-preview-890--asyncapi-website.netlify.app/

@quetzalliwrites
Copy link
Member

@mcturco isn't a codeowner yet?!?

@derberg
Copy link
Member

derberg commented Jul 28, 2022

👏🏼
agree 100% !!!

@magicmatatjahu
Copy link
Member Author

@fmvilas Only you left :)

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely 👍 👏

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 10df0d1 into asyncapi:master Jul 28, 2022
@magicmatatjahu magicmatatjahu deleted the chore/add-missy-akshat-codeowners branch July 28, 2022 08:56
@derberg
Copy link
Member

derberg commented Jul 29, 2022

@akshatnema according to the official charter document that defined open governance model at AsyncAPI Initiative, now you have also the right to be part of the Technical Steering Community.

Technically, you need to open a PR to get your name in this file https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json (when you decide to do it, please, with the same PR update info about @mcturco that she is also a maintainer to additional repo).

TSC membership is optional. Some maintainers decided to stay focused on their repositories only.

As a TSC member, you commit to helping decide on things that are done across the whole AsyncAPI Initiative, and not just one repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants