fix: center filter alignment on large screens #3629
Conversation
KishanInnovates
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces minor formatting and consistency changes to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3629--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
pages/blog/index.tsx (2)
100-107: Enhance RSS feed image accessibility.The RSS feed image could benefit from improved accessibility attributes:
<img className='ml-1 text-primary-500 hover:text-primary-300' style={{ display: 'inline' }} src='/img/logos/rss.svg' alt='RSS feed' + role='img' + aria-label='RSS Feed Icon' height='18px' width='18px' />🧰 Tools
🪛 ESLint
[error] 101-101: Replace
"ml-1·text-primary-500·hover:text-primary-300"with'ml-1·text-primary-500·hover:text-primary-300'(prettier/prettier)
[error] 101-101: Unexpected usage of doublequote.
(jsx-quotes)
[error] 103-103: Replace
"/img/logos/rss.svg"with'/img/logos/rss.svg'(prettier/prettier)
[error] 103-103: Unexpected usage of doublequote.
(jsx-quotes)
[error] 104-104: Replace
"RSS·feed"with'RSS·feed'(prettier/prettier)
[error] 104-104: Unexpected usage of doublequote.
(jsx-quotes)
[error] 105-105: Replace
"18px"with'18px'(prettier/prettier)
[error] 105-105: Unexpected usage of doublequote.
(jsx-quotes)
[error] 106-106: Replace
"18px"with'18px'(prettier/prettier)
[error] 106-106: Unexpected usage of doublequote.
(jsx-quotes)
145-151: Improve loading state accessibility.Consider enhancing the loader with ARIA attributes for better accessibility:
<div className='h-screen w-full'> <Loader loaderText='Loading Blogs' className='mx-auto my-60' pulsating + role='status' + aria-live='polite' /> </div>🧰 Tools
🪛 ESLint
[error] 145-145: Replace
"h-screen·w-full"with'h-screen·w-full'(prettier/prettier)
[error] 145-145: Unexpected usage of doublequote.
(jsx-quotes)
[error] 146-150: Replace
⏎··················loaderText="Loading·Blogs"⏎··················className="mx-auto·my-60"⏎··················pulsating⏎···············with·loaderText='Loading·Blogs'·className='mx-auto·my-60'·pulsating(prettier/prettier)
[error] 147-147: Unexpected usage of doublequote.
(jsx-quotes)
[error] 148-148: Unexpected usage of doublequote.
(jsx-quotes)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/blog/index.tsx(2 hunks)
🧰 Additional context used
🪛 ESLint
pages/blog/index.tsx
[error] 35-35: Delete ,
(prettier/prettier)
[error] 35-35: Unexpected trailing comma.
(comma-dangle)
[error] 42-42: Delete ,
(prettier/prettier)
[error] 42-42: Unexpected trailing comma.
(comma-dangle)
[error] 46-46: Delete ,
(prettier/prettier)
[error] 46-46: Unexpected trailing comma.
(comma-dangle)
[error] 49-49: Delete ,
(prettier/prettier)
[error] 49-49: Unexpected trailing comma.
(comma-dangle)
[error] 50-50: Delete ,
(prettier/prettier)
[error] 50-50: Unexpected trailing comma.
(comma-dangle)
[error] 54-54: Delete ,
(prettier/prettier)
[error] 54-54: Unexpected trailing comma.
(comma-dangle)
[error] 67-67: Replace "Blog" with 'Blog'
(prettier/prettier)
[error] 67-67: Unexpected usage of doublequote.
(jsx-quotes)
[error] 68-71: Replace ⏎········className="relative·px-4·pb-20·pt-8·sm:px-6·lg:px-8·lg:pb-28·lg:pt-12"⏎········id="main-content"⏎······ with ·className='relative·px-4·pb-20·pt-8·sm:px-6·lg:px-8·lg:pb-28·lg:pt-12'·id='main-content'
(prettier/prettier)
[error] 69-69: Unexpected usage of doublequote.
(jsx-quotes)
[error] 70-70: Unexpected usage of doublequote.
(jsx-quotes)
[error] 72-72: Replace "absolute·inset-0" with 'absolute·inset-0'
(prettier/prettier)
[error] 72-72: Unexpected usage of doublequote.
(jsx-quotes)
[error] 73-73: Replace "h-1/3·bg-white·sm:h-2/3" with 'h-1/3·bg-white·sm:h-2/3'
(prettier/prettier)
[error] 73-73: Unexpected usage of doublequote.
(jsx-quotes)
[error] 75-75: Replace "relative·mx-auto·max-w-7xl" with 'relative·mx-auto·max-w-7xl'
(prettier/prettier)
[error] 75-75: Unexpected usage of doublequote.
(jsx-quotes)
[error] 76-76: Replace "text-center" with 'text-center'
(prettier/prettier)
[error] 76-76: Unexpected usage of doublequote.
(jsx-quotes)
[error] 80-80: Replace "mx-auto·mt-3·max-w-2xl·sm:mt-4" with 'mx-auto·mt-3·max-w-2xl·sm:mt-4'
(prettier/prettier)
[error] 80-80: Unexpected usage of doublequote.
(jsx-quotes)
[error] 83-86: Replace ⏎··············typeStyle={ParagraphTypeStyle.md}⏎··············className="mx-auto·mt-4·max-w-2xl"⏎············ with ·typeStyle={ParagraphTypeStyle.md}·className='mx-auto·mt-4·max-w-2xl'
(prettier/prettier)
[error] 85-85: Unexpected usage of doublequote.
(jsx-quotes)
[error] 88-91: Replace ⏎················href="https://github.com/asyncapi/website/issues/new?template=blog.md"⏎················target="_blank"⏎·············· with ·href='https://github.com/asyncapi/website/issues/new?template=blog.md'·target='_blank'
(prettier/prettier)
[error] 89-89: Unexpected usage of doublequote.
(jsx-quotes)
[error] 90-90: Unexpected usage of doublequote.
(jsx-quotes)
[error] 95-98: Replace ⏎··············typeStyle={ParagraphTypeStyle.md}⏎··············className="mx-auto·mt-1·max-w-2xl"⏎············ with ·typeStyle={ParagraphTypeStyle.md}·className='mx-auto·mt-1·max-w-2xl'
(prettier/prettier)
[error] 97-97: Unexpected usage of doublequote.
(jsx-quotes)
[error] 101-101: Replace "ml-1·text-primary-500·hover:text-primary-300" with 'ml-1·text-primary-500·hover:text-primary-300'
(prettier/prettier)
[error] 101-101: Unexpected usage of doublequote.
(jsx-quotes)
[error] 103-103: Replace "/img/logos/rss.svg" with '/img/logos/rss.svg'
(prettier/prettier)
[error] 103-103: Unexpected usage of doublequote.
(jsx-quotes)
[error] 104-104: Replace "RSS·feed" with 'RSS·feed'
(prettier/prettier)
[error] 104-104: Unexpected usage of doublequote.
(jsx-quotes)
[error] 105-105: Replace "18px" with '18px'
(prettier/prettier)
[error] 105-105: Unexpected usage of doublequote.
(jsx-quotes)
[error] 106-106: Replace "18px" with '18px'
(prettier/prettier)
[error] 106-106: Unexpected usage of doublequote.
(jsx-quotes)
[error] 108-108: Replace "/rss.xml" with '/rss.xml'
(prettier/prettier)
[error] 108-108: Unexpected usage of doublequote.
(jsx-quotes)
[error] 111-111: Replace "mx:64·mt-12·md:flex·md:justify-center·lg:justify-center" with 'mx:64·mt-12·md:flex·md:justify-center·lg:justify-center'
(prettier/prettier)
[error] 111-111: Unexpected usage of doublequote.
(jsx-quotes)
[error] 115-115: Replace "md:·mx-px·mt-1·w-full·md:mt-0·md:w-1/5·md:text-sm" with 'md:·mx-px·mt-1·w-full·md:mt-0·md:w-1/5·md:text-sm'
(prettier/prettier)
[error] 115-115: Unexpected usage of doublequote.
(jsx-quotes)
[error] 120-120: Replace "button" with 'button'
(prettier/prettier)
[error] 120-120: Unexpected usage of doublequote.
(jsx-quotes)
[error] 121-121: Replace "bg-none·text-md·mt-1·rounded-md·border·border-gray-200·px-4·py-2·font-semibold·tracking-heading·text-gray-800·shadow-none·transition-all·duration-500·ease-in-out·hover:text-gray-700·md:mt-0·md:py-0" with 'bg-none·text-md·mt-1·rounded-md·border·border-gray-200·px-4·py-2·font-semibold·tracking-heading·text-gray-800·shadow-none·transition-all·duration-500·ease-in-out·hover:text-gray-700·md:mt-0·md:py-0'
(prettier/prettier)
[error] 121-121: Unexpected usage of doublequote.
(jsx-quotes)
[error] 124-124: Replace "inline-block" with 'inline-block'
(prettier/prettier)
[error] 124-124: Unexpected usage of doublequote.
(jsx-quotes)
[error] 130-130: Replace "mt-16·flex·flex-col·items-center·justify-center" with 'mt-16·flex·flex-col·items-center·justify-center'
(prettier/prettier)
[error] 130-130: Unexpected usage of doublequote.
(jsx-quotes)
[error] 132-134: Replace "mx-auto·mt-3·max-w-2xl·text-xl·leading-7·text-gray-500">⏎··················No·post·matches·your·filter⏎················ with 'mx-auto·mt-3·max-w-2xl·text-xl·leading-7·text-gray-500'>No·post·matches·your·filter
(prettier/prettier)
[error] 132-132: Unexpected usage of doublequote.
(jsx-quotes)
[error] 138-138: Replace "mx-auto·mt-12·grid·max-w-lg·gap-5·lg:max-w-none·lg:grid-cols-3" with 'mx-auto·mt-12·grid·max-w-lg·gap-5·lg:max-w-none·lg:grid-cols-3'
(prettier/prettier)
[error] 138-138: Unexpected usage of doublequote.
(jsx-quotes)
[error] 145-145: Replace "h-screen·w-full" with 'h-screen·w-full'
(prettier/prettier)
[error] 145-145: Unexpected usage of doublequote.
(jsx-quotes)
[error] 146-150: Replace ⏎··················loaderText="Loading·Blogs"⏎··················className="mx-auto·my-60"⏎··················pulsating⏎··············· with ·loaderText='Loading·Blogs'·className='mx-auto·my-60'·pulsating
(prettier/prettier)
[error] 147-147: Unexpected usage of doublequote.
(jsx-quotes)
[error] 148-148: Unexpected usage of doublequote.
(jsx-quotes)
⏰ Context from checks skipped due to timeout of 180000ms (3)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
🔇 Additional comments (1)
pages/blog/index.tsx (1)
111-111: Filter alignment change looks good!The change from
lg:justify-starttolg:justify-centersuccessfully addresses the alignment issue on large screens, meeting the PR objective.🧰 Tools
🪛 ESLint
[error] 111-111: Replace
"mx:64·mt-12·md:flex·md:justify-center·lg:justify-center"with'mx:64·mt-12·md:flex·md:justify-center·lg:justify-center'(prettier/prettier)
[error] 111-111: Unexpected usage of doublequote.
(jsx-quotes)
| @@ -32,26 +32,26 @@ export default function BlogIndexPage() { | |||
|
|
|||
| return i2Date.getTime() - i1Date.getTime(); | |||
| }) | |||
| : [] | |||
| : [], | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix code style issues flagged by ESLint.
- Remove trailing commas as they're disallowed by the project's ESLint configuration:
- navItems ? navItems.sort(...) : [],
+ navItems ? navItems.sort(...) : []Similar fixes needed for other trailing commas.
- Use single quotes consistently in JSX attributes:
- <GenericLayout title="Blog" description={description} image={image} wide>
+ <GenericLayout title='Blog' description={description} image={image} wide>Similar fixes needed for other JSX attributes.
Also applies to: 42-42, 46-46, 49-49, 50-50, 54-54, 67-150
🧰 Tools
🪛 ESLint
[error] 35-35: Delete ,
(prettier/prettier)
[error] 35-35: Unexpected trailing comma.
(comma-dangle)
Problem
lg:justify-start).Solution
lg:justify-starttolg:justify-centerto properly center it.Issue Link
Summary by CodeRabbit