feat: add-all-generator-templates-manually #3618
Conversation
Light13008
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request focuses on updating the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3618 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3618--asyncapi-website.netlify.app/ |
Light13008
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/tools-manual.json (1)
34-38: Consider enhancing template descriptions and metadata.To improve user experience, consider:
- Adding version information for each template
- Expanding descriptions to include:
- Supported AsyncAPI versions
- Minimum requirements
- Example usage
Also applies to: 46-50, 58-62, 70-74, 82-86, 94-98, 106-110
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/tools-manual.json(1 hunks)
🔇 Additional comments (3)
config/tools-manual.json (3)
32-118: LGTM! Well-structured template entries.The added generator templates follow a consistent structure and format.
39-43: LGTM! Consistent categorization and technology tags.Each template entry has appropriate and consistent categorization with:
- Specific language tag
- Relevant technology tags
- Consistent "generator-template" category
Also applies to: 51-55, 63-67, 75-79, 87-91, 99-103, 111-115
37-37: Verify repository existence and accessibility.Let's ensure all the referenced repositories exist and are accessible.
Also applies to: 49-49, 61-61, 73-73, 85-85, 97-97, 109-109
✅ Verification successful
All repository URLs are valid and accessible
All referenced AsyncAPI template repositories are confirmed to exist and are publicly accessible on GitHub.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the repositories exist and are accessible repos=( "asyncapi/go-watermill-template" "asyncapi/nodejs-template" "asyncapi/markdown-template" "asyncapi/python-paho-template" "asyncapi/dotnet-rabbitmq-template" "asyncapi/nodejs-ws-template" "asyncapi/ts-nats-template" ) for repo in "${repos[@]}"; do echo "Checking $repo..." response=$(curl -s -o /dev/null -w "%{http_code}" "https://github.com/$repo") if [ "$response" != "200" ]; then echo "Repository $repo returned status $response" fi doneLength of output: 1947
Light13008
changed the title
Light13008
changed the title
Light13008
changed the title
Description
tools-manual.json, but as for now, the changes are not getting reflected on Tools Page locally.Summary by CodeRabbit