-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enabling i18n feature for smaller screens #3556
Merged
akshatnema
merged 26 commits into
asyncapi:master
from
devilkiller-ag:i18n-for-smaller-screen
Feb 11, 2025
+142
−53
Merged
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d152a10
added langauge option in mobile navbar
devilkiller-ag 57955e1
updated locale names
devilkiller-ag 6879ec8
added functionality to highlight current language
devilkiller-ag eec0f74
added language icon
devilkiller-ag 9e7a307
fixed nav items spacing
devilkiller-ag ac2f811
updated add translations doc
devilkiller-ag 616595b
updated add translations doc
devilkiller-ag 00edd38
Update components/icons/Language.tsx
devilkiller-ag 3c64066
Merge branch 'asyncapi:master' into i18n-for-smaller-screen
devilkiller-ag 2e48227
Merge branch 'master' into i18n-for-smaller-screen
akshatnema f2fd10f
Merge branch 'master' into i18n-for-smaller-screen
anshgoyalevil 2e8e958
Merge branch 'asyncapi:master' into i18n-for-smaller-screen
devilkiller-ag 18aaff7
refactor: revert localname from full form to first-two-letters
devilkiller-ag ecf4f1a
refactor: removed need to change locale display name at multiple places
devilkiller-ag a0e3fe7
fix: lint issues
devilkiller-ag 86b09fc
chore: removed usage of lib in the translation doc
devilkiller-ag b9a7d0d
Merge branch 'master' into i18n-for-smaller-screen
asyncapi-bot 9222342
Merge branch 'master' into i18n-for-smaller-screen
devilkiller-ag 2547f5f
updated doc
devilkiller-ag e1e0e10
updated language name to full name in options
devilkiller-ag 7efaed2
fixed linting issue
devilkiller-ag 972252f
Merge branch 'master' into i18n-for-smaller-screen
anshgoyalevil e204776
refactor: moved langmap to next-i18next.config.js
devilkiller-ag da77462
Merge branch 'i18n-for-smaller-screen' of https://github.com/devilkil…
devilkiller-ag e835e66
updated adding translation readme
devilkiller-ag e9a68fa
Merge branch 'master' into i18n-for-smaller-screen
anshgoyalevil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import React from 'react'; | ||
|
||
/* eslint-disable max-len */ | ||
/** | ||
* @description Language Icon for language selector component | ||
*/ | ||
export default function IconLanguage({ className = '' }) { | ||
return ( | ||
<svg | ||
xmlns='http://www.w3.org/2000/svg' | ||
fill='none' | ||
viewBox='0 0 24 24' | ||
strokeWidth={1.5} | ||
stroke='currentColor' | ||
className={`size-5 ${className}`} | ||
> | ||
<path | ||
strokeLinecap='round' | ||
strokeLinejoin='round' | ||
d='m10.5 21 5.25-11.25L21 21m-9-3h7.5M3 5.621a48.474 48.474 0 0 1 6-.371m0 0c1.12 0 2.233.038 3.334.114M9 5.25V3m3.334 2.364C11.176 10.658 7.69 15.08 3 17.502m9.334-12.138c.896.061 1.785.147 2.666.257m-4.589 8.495a18.023 18.023 0 0 1-3.827-5.802' | ||
/> | ||
</svg> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
module.exports = { | ||
i18n: { | ||
locales: ['en', 'de'], | ||
defaultLocale : 'en', | ||
namespaces: ['landing-page', 'common', 'tools'], | ||
defaultNamespace: 'landing-page', | ||
react: { useSuspense: false },// this line | ||
}, | ||
|
||
}; | ||
i18n: { | ||
locales: ['en', 'de'], | ||
defaultLocale: 'en', | ||
namespaces: ['landing-page', 'common', 'tools'], | ||
defaultNamespace: 'landing-page', | ||
react: { useSuspense: false },// this line | ||
anshgoyalevil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
langMap: { | ||
en: 'English', | ||
de: 'Deutsch' | ||
}, | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes related to
en
->english
here and in i18n config file since URLs should be having smaller prefixThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I will do that!