Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conf banner alignment fix #2356

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: conf banner alignment fix #2356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f8da31
alignment fix
vishvamsinh28 Nov 28, 2023
1713fc7
tests file updated
vishvamsinh28 Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/campaigns/AnnoucementHero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export default function AnnouncementHero({ className = '', small = false, hideVi
<div className="h-8 w-8 rounded-full bg-primary-500 hover:bg-primary-600 cursor-pointer mb-2 absolute left-0 z-10 top-1/2 transform -translate-y-1/2 opacity-50 md:opacity-100 flex justify-center items-center" onClick={goToPrevious}>
<ArrowLeft className='w-4 text-white' />
</div>
<div className='relative w-5/6 flex flex-col gap-2 justify-center items-center'>
<div className='relative w-5/6 pr-3 flex flex-col gap-2 justify-center items-center'>
<div className='relative w-full h-[18rem] lg:w-[38rem] lg:h-[17rem] overflow-hidden'>
{banners.map((banner, index) => (
banner.show && (
Expand Down
4 changes: 2 additions & 2 deletions cypress/test/pages/community/dashboard.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe('Integration Test for Dashboard ', () => {
cy.contains('asyncapi/generator');
cy.contains('docs')
//check if this is not selected options are not displayed
cy.should('not.contain', 'asyncapi/community');
cy.should('not.contain', 'javascript');
// cy.should('not.contain', 'asyncapi/community');
Copy link
Member

@derberg derberg Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened a followup #2357

no time to fix it now, blocking all PRs

// cy.should('not.contain', 'javascript');
});
});