Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update banner link #2343

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

thulieblack
Copy link
Member

No description provided.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be7f1b5
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/655cef1e0ad2b1000880e8c4
😎 Deploy Preview https://deploy-preview-2343--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Nov 21, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2343--asyncapi-website.netlify.app/

@thulieblack
Copy link
Member Author

thulieblack commented Nov 21, 2023

@akshatnema please help the Bangalore button keeps redirecting to the APIday Paris tickets

cc @derberg

@akshatnema
Copy link
Member

@thulieblack fixed the bug

@derberg
Copy link
Member

derberg commented Nov 21, 2023

but then banners are not automatically changing

@derberg
Copy link
Member

derberg commented Nov 21, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 69b0f05 into asyncapi:master Nov 21, 2023
17 of 18 checks passed
@thulieblack thulieblack deleted the banner-update branch November 22, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants