-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unit tests for newsroom-videos scripts #1988
Merged
asyncapi-bot
merged 12 commits into
asyncapi:master
from
reachaadrika:scripts_newsroom_meetings_tests
Jul 31, 2023
Merged
feat: add unit tests for newsroom-videos scripts #1988
asyncapi-bot
merged 12 commits into
asyncapi:master
from
reachaadrika:scripts_newsroom_meetings_tests
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachaadrika
requested review from
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee and
asyncapi-bot-eve
as code owners
July 24, 2023 20:14
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
reachaadrika
changed the title
feat : adding tests for scripts folder - newsroom_videos and build-meetings
feat: add tests for scripts folder - newsroom_videos and build-meetings
Jul 24, 2023
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1988--asyncapi-website.netlify.app/ |
reachaadrika
changed the title
feat: add tests for scripts folder - newsroom_videos and build-meetings
feat: add unit tests for meetings and newsroom-videos pages
Jul 24, 2023
akshatnema
added
the
gsoc
This label should be used for issues or discussions related to ideas for Google Summer of Code
label
Jul 25, 2023
…reachaadrika/website into scripts_newsroom_meetings_tests
reachaadrika
changed the title
feat: add unit tests for meetings and newsroom-videos pages
feat: add unit tests for newsroom-videos scripts
Jul 30, 2023
akshatnema
requested changes
Jul 30, 2023
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
akshatnema
approved these changes
Jul 31, 2023
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
gsoc
This label should be used for issues or discussions related to ideas for Google Summer of Code
ready-to-merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
fixes #1987