Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve CSS issues in the roadmap item modal #1918

Merged
merged 6 commits into from
Jul 17, 2023
Merged

fix: resolve CSS issues in the roadmap item modal #1918

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7a0cff
fix: CSS issues in the roadmap item modal
codingmickey Jul 8, 2023
22cc54a
fix: formatting changes in Modal.js
codingmickey Jul 11, 2023
18f8348
Merge branch 'master' into fix/roadmap_modal
codingmickey Jul 11, 2023
c6091d1
refactor: applying the suggestion of height fixes in different viewpo…
codingmickey Jul 15, 2023
2858c75
Merge branch 'master' into fix/roadmap_modal
codingmickey Jul 15, 2023
2a33a46
Merge branch 'master' into fix/roadmap_modal
akshatnema Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/Modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ export default function Modal({
}

return (
<div ref={modalRef} tabIndex={-1} className="backdrop-blur bg-black/30 fixed inset-0 z-30 flex min-h-full items-end justify-center p-4 text-center sm:items-center sm:p-0" onClick={backdropClickHandler} onKeyUp={onKeyUpHandler}>
<div className="relative transform overflow-hidden rounded-lg bg-white px-4 pt-5 pb-4 text-left shadow-xl transition-all sm:my-8 sm:w-full sm:max-w-4xl sm:p-6">
<div ref={modalRef} tabIndex={-1} className="backdrop-blur bg-black/30 fixed inset-0 z-30 flex min-h-full items-end justify-center p-4 text-center sm:items-center sm:p-0 my-auto mt-2" onClick={backdropClickHandler} onKeyUp={onKeyUpHandler}>
<div className="relative transform overflow-hidden rounded-lg bg-white px-4 pt-5 pb-4 text-left shadow-xl transition-all m-auto sm:w-full sm:max-w-4xl sm:p-6">
<div className="flex justify-between mb-6">
<h1 className="text-lg font-bold truncate mr-4">{title}</h1>
<button onClick={() => onModalClose()} data-testid="Modal-close">
Expand All @@ -32,7 +32,7 @@ export default function Modal({
</svg>
</button>
</div>
<div className="w-full overflow-auto max-h-120">
<div className="w-full overflow-auto lg:max-h-[70vh] max-h-[65vh]">
{children}
</div>
</div>
Expand Down