chore: adjust address for reply #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested review from
thulieblack and
quetzalliwrites
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1807--asyncapi-website.netlify.app/ |
derberg
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
thanks 🙏🏼
for others some good amount of knowledge about request/reply -> https://asyncapi.slack.com/archives/CH44ZMJAZ/p1686741430319269
|
/rtm |
thulieblack
approved these changes
Jun 19, 2023
|
/rtm |
|
@thulieblack might need you to merge it manually 🤔 |
|
/rtm |
|
merging reacts to
but since there was no approval, it was added later, then merge was skipped
just fyi why merging was not triggered until I removed and added label again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some back and furth with @derberg its better to use
address: "/"then null.