feat: adding unit tests for sponsors component #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachaadrika
requested review from
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1804--asyncapi-website.netlify.app/ |
akshatnema
added
the
gsoc
akshatnema
reviewed
Jul 8, 2023
cypress/test/sponsors/sponsors.cy.js
Outdated
| @@ -0,0 +1,37 @@ | |||
| import { mount } from 'cypress/react'; | |||
There was a problem hiding this comment.
Make the filename as Sponsors.cy.js.
akshatnema
approved these changes
Jul 10, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All these were standalone files in the codebase , for ease of navigation and additional refactoring , I added these files into a single folder and updated the imports , so that this is not a breaking change .
Along with this for writing unit tests , the code required some additional refactoring , earlier each sponsor was added separately in an li tag with image associated with , I instead of following this approach created an array of sponsors with all necessary classes and fetched and mapped the data through it . So that we need to change the data and testcases , if a new sponsor is added to the list in future . We could update the array , and it would reflect both in application code as well as the test file .
For this I created 3 files : SponsorsList.js , GoldSponsorsList.js and SilverSponsorsList.js .
Further following are the tests and test files for each of the Sponsors file :
Here I included the following test cases :
GoldSponsors.js**
Here are the tests that I included :
-renders the gold sponsors
SilverSponsors.js
NOTE : Along with unit tests this PR includes additional code refactoring
Related issue(s)
fixes #1803