Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding unit tests for docsCards and feature folders #1763
feat: adding unit tests for docsCards and feature folders #1763
Changes from 5 commits
eee20e5
f3c7f2a
39a9131
bb70073
68895c6
59c548b
2003277
20c1f90
a601b11
87eebb8
cdfedd9
a06a25d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use data buckets here as we use it in DocCards.js. This will maintain consistency among the codebase and we need not to update the things at 2 places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done , I have resolved the failing test also took the updated data from buckets file
![image](https://private-user-images.githubusercontent.com/64789514/246600246-4152d3e3-f8e1-464a-b2fc-5d7afcc8dff1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzEwODMsIm5iZiI6MTczOTMzMDc4MywicGF0aCI6Ii82NDc4OTUxNC8yNDY2MDAyNDYtNDE1MmQzZTMtZjhlMS00NjRhLWIyZmMtNWQ3YWZjYzhkZmYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAzMjYyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg3M2I1ZGI2ZmJmZGM1ZDQzYzI3NDIxNWFkMDYyZjI1ZTVjMTYxZDBhNmQwMDg3ODdkODA2MGM5ODJkZjY4NGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.rC-FxS46XFep85eMM3TZjdV5YE-EintxJEkyvyShYsw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you require slight refactoring inside the codebase. Even inside the
features/index.jsx
, kindly export this array into separate file in same folder and use this array in both code and test file to maintain consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done , created a different file and exported the features list