Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm modelina files and folders #1739

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Conversation

anshgoyalevil
Copy link
Member

Description
This PR removes modelina playground specific code.

Related issue(s)

fixes #1732

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 48134ee
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6493f9b87518790007f3b4b8
😎 Deploy Preview https://deploy-preview-1739--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1739--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

hey @anshgoyalevil
Nice work, but @derberg has gone for a conference so we need to wait for his approval

@anshgoyalevil
Copy link
Member Author

@sambhavgupta0705 Sure. 🛩️

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705 since you are the author of the issue, all good on your side to merge this?

@sambhavgupta0705
Copy link
Member

@derberg Yes it looks good to me 👍🏻
great work @anshgoyalevil

@derberg
Copy link
Member

derberg commented Jun 22, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 4c5f359 into asyncapi:master Jun 22, 2023
@anshgoyalevil anshgoyalevil deleted the mode branch June 22, 2023 10:29
@derberg
Copy link
Member

derberg commented Jun 22, 2023

@allcontributors please add @anshgoyalevil for code

@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @anshgoyalevil! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove modelina playground specific code
4 participants