feat: adding unit tests for dashboard folder #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachaadrika
requested review from
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1735--asyncapi-website.netlify.app/ |
reachaadrika
changed the title
akshatnema
added
the
gsoc
akshatnema
requested changes
Jun 3, 2023
| // Select a specific repository | ||
| cy.get('select[name="selectedRepo"]').select('Repository 1'); | ||
| // Assert that the table displays the filtered issues | ||
| cy.get(Table).should('contain', 'Repository 3'); |
There was a problem hiding this comment.
If repository 1 is selected, then why are we checking for Repository 3 to exist in the render.
There was a problem hiding this comment.
done the required changes in current commit .
akshatnema
reviewed
Jun 3, 2023
Comment on lines
8
to
16
| <Filters | ||
| className="test-class" | ||
| issues={[]} | ||
| setSelectedRepo={() => {}} | ||
| allIssues={[]} | ||
| setSelectedArea={() => {}} | ||
| selectedArea="" | ||
| selectedRepo="" | ||
| /> |
There was a problem hiding this comment.
Test for filters shouldn't be tested only for it's existence, it's important that we should test it's functionality too by passing correct attributes inside it.
There was a problem hiding this comment.
done the required changes in current commit .
akshatnema
requested changes
Jun 3, 2023
akshatnema
requested changes
Jul 8, 2023
akshatnema
requested changes
Jul 8, 2023
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
akshatnema
reviewed
Jul 9, 2023
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
akshatnema
requested changes
Jul 10, 2023
akshatnema
reviewed
Jul 10, 2023
akshatnema
approved these changes
Jul 11, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dashboard Component of the website mainly houses for the main 2 sections "GoodFirstIssues" and the issues that are trending the most . Along with this it has mini sub components within itself that culminate together to make the Dashboard component . These components are as follows :
Header : Header component has 3 major links , to contribution guide , AsyncAPI github , and the slack community link , along with that it houses the heading Dashboard with it . The major things that need to be tested were that all 3 links are opened in new tab , heading is displayed and all the buttons and links are in place and open to new tabs . I have wrapped up all these tests and assertions in a single test "renders header correctly " so that we could also see what the component looks like in the test runner too .
GoodFirstIssues Tip : On hovering over this icon it displays basic and small text . I wrote 2 tests for this component "toggles the tip when hovering over the icon" and "renders the tip content with the correct text" . Both these tests passed .
GoodFirstIssues.js : This component culminates other components like Tooltip , filter and others like row and table . This component displays a list of good first issues from github repos and also filters then according to the area and repo that has been selected , it displays them in a row like format . I included 3 major tests , "renders the component correctly " , "filter issues on basis of repository " , and similarly "filters on the basis of area " . I used dummy data for testing purpose .
Along with this it has a bunch of Helper components too , like Table , Row and Filters . I individually have tests for these components too which are as follows :
Row
Table
7**. Filters**
NOTE : THESE ARE SMALL COMPONENT TESTS , WHICH WOULD BE IN FUTURE BE TAKEN CARE OFF WHILE INTEGRATION TESTING
Related issue(s)
fixes #1729