fix: social links of ambassadors are not redirecting to correct link #1581 #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
777Prabhjot
requested review from
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1583--asyncapi-website.netlify.app/ |
777Prabhjot
changed the title
akshatnema
requested changes
Apr 21, 2023
pages/community/ambassadors/index.js
Outdated
| @@ -161,23 +161,23 @@ function Index() { | |||
| <div className="p-2 text-sm">{ambassador.bio}</div> | |||
| <div className="border-t p-2 flex"> | |||
| <a | |||
| href={`https://www.twitter.com/${ambassador.twitterUrl}`} | |||
| href={`${ambassador.twitterUrl}`} | |||
There was a problem hiding this comment.
Suggested change
| href={`${ambassador.twitterUrl}`} | |
| href={ambassador.twitterUrl} |
pages/community/ambassadors/index.js
Outdated
| target="_blank" | ||
| rel="noreferrer" | ||
| className="underline" | ||
| > | ||
| Twitter ↗ | ||
| </a> | ||
| <a | ||
| href={`https://www.github.com/${ambassador.githubUrl}`} | ||
| href={`${ambassador.githubUrl}`} |
There was a problem hiding this comment.
Suggested change
| href={`${ambassador.githubUrl}`} | |
| href={ambassador.githubUrl} |
pages/community/ambassadors/index.js
Outdated
| target="_blank" | ||
| rel="noreferrer" | ||
| className="underline ml-3" | ||
| > | ||
| Github ↗ | ||
| </a> | ||
| <a | ||
| href={`https://www.linkedin.com/in/${ambassador.linkedinUrl}`} | ||
| href={`${ambassador.linkedinUrl}`} |
There was a problem hiding this comment.
Suggested change
| href={`${ambassador.linkedinUrl}`} | |
| href={ambassador.linkedinUrl} |
|
@akshatnema done |
akshatnema
approved these changes
Apr 22, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey issue is solved please check it out