Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ambassador video Issue #1546 #1548

Merged
merged 7 commits into from
Apr 13, 2023
Merged

Conversation

yuvrxj-afk
Copy link
Contributor

@yuvrxj-afk yuvrxj-afk commented Apr 11, 2023

Description

  • Added Ambassador video to the website's community/ambassador page.
  • added HTML entities.
  • removed extra {bg-center} styling.

Related issue(s)
Fixes #1546

@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 85c36d1
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6437d05e18d2590008b897f7
😎 Deploy Preview https://deploy-preview-1548--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sambhavgupta0705
Copy link
Member

@yuvrxj-afk please follow the correct pr title convention 😄

@yuvrxj-afk yuvrxj-afk closed this Apr 11, 2023
@yuvrxj-afk yuvrxj-afk changed the title Added ambassador video Issue #1546 Feat: Added ambassador video Issue #1546 Apr 11, 2023
@yuvrxj-afk yuvrxj-afk reopened this Apr 11, 2023
@github-actions
Copy link

github-actions bot commented Apr 11, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 29
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1548--asyncapi-website.netlify.app/

@yuvrxj-afk yuvrxj-afk changed the title Feat: Added ambassador video Issue #1546 feat: Added ambassador video Issue #1546 Apr 11, 2023
@yuvrxj-afk yuvrxj-afk changed the title feat: Added ambassador video Issue #1546 Feat: added ambassador video Issue #1546 Apr 11, 2023
@yuvrxj-afk yuvrxj-afk changed the title Feat: added ambassador video Issue #1546 feat: added ambassador video Issue #1546 Apr 11, 2023
Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is needed from @Barbanio regarding this first.

pages/community/ambassadors/index.js Outdated Show resolved Hide resolved
@Barbanio
Copy link
Contributor

It looks good to me 🙂

@yuvrxj-afk yuvrxj-afk requested a review from akshatnema April 12, 2023 22:07
@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 5cf8cd8 into asyncapi:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ambassador video to the website
5 participants