Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open TSC members social links in a new tab #1506

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

Olaleye-Blessing
Copy link
Contributor

@Olaleye-Blessing Olaleye-Blessing commented Apr 6, 2023

Description
The social links for each TSC member open in the same tab when they are clicked. This PR makes sure they are opened in another tab.

Related issue(s)

Closes: #1496

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 89de966
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6439261d53ae000008b14429
😎 Deploy Preview https://deploy-preview-1506--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 35
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1506--asyncapi-website.netlify.app/

@Olaleye-Blessing Olaleye-Blessing force-pushed the 1496-tsc-member-links branch 2 times, most recently from d6a8e49 to 645f3ec Compare April 11, 2023 12:16
@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 6de59a1 into asyncapi:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSC member social links aren't opening in new tab
3 participants