Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 404 page design #1462

Merged
merged 9 commits into from
Apr 11, 2023
Merged

feat: 404 page design #1462

merged 9 commits into from
Apr 11, 2023

Conversation

sambhavgupta0705
Copy link
Member

Description

  • ...This PR adds the 404 page to the website.

Related issue(s)

Resolves #1420

@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5014977
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64350d207991ae0008cd37e2
😎 Deploy Preview https://deploy-preview-1462--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 18
🟠 Accessibility 88
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1462--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member Author

@Mayaleeeee @derberg @akshatnema PTAL.
image
image

@Mayaleeeee
Copy link
Member

Nice work @sambhavgupta0705 but is there a reason why you changed the illustration?

@sambhavgupta0705
Copy link
Member Author

sambhavgupta0705 commented Mar 24, 2023 •
edited
Loading

Nice work @sambhavgupta0705 but is there a reason why you changed the illustration?

Thanks Maya.
Yeahh the first reason was ,I wasn't able to find a good quality photo of the new design and while scrolling in the repository I found this picture which is more inclined to the 404 Page.

Second was when I placed the image and text side by side then it was in a long stretch and wasn't looking good so I just add the flex:col property.

@derberg Volta.net
Copy link
Member

derberg commented Mar 30, 2023

@sambhavgupta0705 checks with Barbaño González in our slack, refer to this issue, and ask here for psd files of latest illustration, she has them

@sambhavgupta0705
Copy link
Member Author

ok @derberg

@sambhavgupta0705
Copy link
Member Author

@derberg PTAL

@derberg
Copy link
Member

derberg commented Apr 3, 2023

@Mayaleeeee can you have a look? example https://deploy-preview-1462--asyncapi-website.netlify.app/dupa

@Mayaleeeee
Copy link
Member

Looks good @derberg
Well done @sambhavgupta0705

@derberg Volta.net
Copy link
Member

derberg commented Apr 4, 2023

isn't there something wrong with "alignments" ?

how about 👇

Screenshot 2023-04-04 at 17.00.24.png

@derberg Volta.net
Copy link
Member

derberg commented Apr 4, 2023

@sambhavgupta0705 btw .webp please 🙏

@sambhavgupta0705
Copy link
Member Author

isn't there something wrong with "alignments" ?

how about point_down

Screenshot 2023-04-04 at 17.00.24.png

I liked this more
Will be making changes according to this

@sambhavgupta0705
Copy link
Member Author

@derberg PTAL

@derberg
Copy link
Member

derberg commented Apr 6, 2023

@Mayaleeeee @akshatnema anything from your side?

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Apr 6, 2023 •
edited
Loading

Looks good @derberg

@derberg
Copy link
Member

derberg commented Apr 11, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 4fd5952 into asyncapi:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshatnema akshatnema akshatnema approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@mcturco mcturco Awaiting requested review from mcturco

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design the 404 page
5 participants
@sambhavgupta0705 @Mayaleeeee @derberg @akshatnema @asyncapi-bot