fix: event page update #1449
fix: event page update #1449
Conversation
…into community
…into community
…into community
AceTheCreator
requested review from
quetzalliwrites,
asyncapi-bot-eve,
fmvilas,
derberg,
mcturco,
akshatnema and
magicmatatjahu
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1449--asyncapi-website.netlify.app/ |
|
83 files changed and targets |
Thanks man 😄 |
|
we have banner in asyncapi/community#640 I though your idea was to use it in https://deploy-preview-1449--asyncapi-website.netlify.app/community/events |
Yes, I use this current one you can see in the events as fallbacks when it loads events that don't have a cover. You can't see it now cuz we haven't merged it with master. The new addition to the build-meeting script helps with that |
|
ok for me, @akshatnema if you approve, we can merge |
There was a problem hiding this comment.
@AceTheCreator I can't see any list of events of the recorded/previous events. Aren't we storing it in some json file?
You can't see them because they don't exist yet, but the new addition to generate-meeting script is going to ensure that |
|
/rtm |
Sorted the list of events on the event page and changed the title on the community navbar from "Meetings" to "Events."
#917
cc @akshatnema