Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed Clear Filter Bug #1423

Merged
merged 9 commits into from
Mar 31, 2023
Merged

Conversation

Savio629
Copy link
Contributor

Description

  • Initially, the clear filter button was used to exit.
  • Now it keeps the dropdown open and updates the UI properly.

Related issue(s)

Preview

Tools._.AsyncAPI.Initiative.for.event-driven.APIs.-.Brave.2023-03-13.01-13-01.mp4

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 521a3b1
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6426aaef1d7cb60008321d0a
😎 Deploy Preview https://deploy-preview-1423--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

github-actions bot commented Mar 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟠 Accessibility 88
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1423--asyncapi-website.netlify.app/

@Savio629 Savio629 changed the title Fixed Clear Filter Bug fix : Fixed Clear Filter Bug Mar 12, 2023
@Savio629 Savio629 changed the title fix : Fixed Clear Filter Bug fix: Fixed Clear Filter Bug Mar 12, 2023
@Savio629 Savio629 changed the title fix: Fixed Clear Filter Bug fix: fixed Clear Filter Bug Mar 12, 2023
@akshatnema
Copy link
Member

Hey @Savio629, can you change this button to a completely new functionality like Undo Changes inside the Filter Menu? because we no longer need Clear Filters button inside the menu, instead we need a small click text button (same as right now) of Undo changes to undo the filters the user selected, compared to the filters stored in the context. So, for example, if a user selected certain filters after opening the menu and didn't click Apply Filters but want to undo the changes he made right now and go back to the previous filtered/no filter condition, so he can use this Undo changes button. Can you make this button in this PR?

@Savio629
Copy link
Contributor Author

@akshatnema So after clicking on Undo Changes button the filter should revert back to its previous state on which the filter is rendering at the moment.
I'll try to implement the feature.

@Savio629
Copy link
Contributor Author

Tools._.AsyncAPI.Initiative.for.event-driven.APIs.-.Brave.2023-03-30.16-08-57.mp4

@akshatnema Done!
We don't need clearFilters button anymore, right?

@akshatnema akshatnema linked an issue Mar 31, 2023 that may be closed by this pull request
@akshatnema
Copy link
Member

We don't need clearFilters button anymore, right?

Yes we don't need Clear Filters button in the Filters Menu.

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit be83528 into asyncapi:master Mar 31, 2023
@Savio629 Savio629 deleted the savio01-clearfilter branch April 7, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear Filter exits the Filter Dropdown
3 participants