fix: more enhancement to UI #1402

AceTheCreator · 2023-03-06T21:23:39Z

I added a few enhancements based on suggested feedback

Converted all used image formats from other formats to webp
Fix duplicate images
Removed unused code
Created community components to hold the necessary component
Added more community highlights to the community homepage

cc @derberg @alequetzalli @akshatnema

#917

…o community

…into community

netlify · 2023-03-06T21:23:45Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`06dc3bb`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/641042474cd22c00082a56ce
😎 Deploy Preview	https://deploy-preview-1402--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

akshatnema · 2023-03-07T10:44:51Z

components/community/Card.js

+        <Paragraph textColor={bg && 'text-gray-400'}>{description}</Paragraph>
+      </div>
+      <div className="mt-10">
+        <Link href={link}>


There should be a <a> tag below this Link component.

Any reason why?

The browser isn't able to recognize it as a link when you right-click on it.

akshatnema

Please add some shadows to these cards as they look slightly odd from all the cards you made above.

akshatnema

Please make this heading in TSC on text-2xl only.

AceTheCreator · 2023-03-08T13:21:04Z

Please make this heading in TSC on text-2xl only.

I don't it's related to this PR :)

AceTheCreator · 2023-03-08T13:23:16Z

@derberg, you might wanna take a look at this PR... It addresses your comment here --> There is one problem I have with whatever I see when going to /community. There are highlights only of items that you added in this PR. But what about TSC? contributor dashboard? newsroom?

derberg · 2023-03-08T14:14:47Z

I love it all, thanks so much for taking my feedback into account 🙏🏼

quetzalliwrites · 2023-03-09T02:23:34Z

pages/community/index.js

+            description="Discover over 100s of interesting issues, suitable for both new
+          contributors and existing contributors."


Suggested change

description="Discover over 100s of interesting issues, suitable for both new

contributors and existing contributors."

description="Discover over 100s of interesting issues, suitable for new and existing contributors."

quetzalliwrites · 2023-03-09T02:24:57Z

pages/community/index.js

+            <Card
+              type="small"
+              taglineBg=""
+              tagline="Rockstars"


Suggested change

tagline="Rockstars"

tagline="Contributors"

pages/community/index.js

quetzalliwrites · 2023-03-09T02:28:02Z

pages/community/index.js

+            <Card
+              type="small"
+              tagline="Community"
+              icon="🚀"


Suggested change

icon="🚀"

icon="🎯"

quetzalliwrites · 2023-03-09T02:28:17Z

pages/community/index.js

+            heading="Meet Folks that are Redefining the Initiative"
+            description="Learn how to become a technical steering committee member and see our current tsc members."
+            tagline="Projection"
+            icon="🎯"


Suggested change

icon="🎯"

icon="🚀"

quetzalliwrites · 2023-03-09T02:28:50Z

pages/community/index.js

+            taglineBg="bg-primary-200"
+            heading="Meet Folks that are Redefining the Initiative"
+            description="Learn how to become a technical steering committee member and see our current tsc members."
+            tagline="Projection"


Suggested change

tagline="Projection"

tagline="TSC"

Yeah... Projection doesn't really say anything to me here, I think we should be clear and direct.

quetzalliwrites · 2023-03-09T02:29:09Z

pages/community/index.js

+        <div className="md:w-[50%] mt-10 md:mt-0">
+          <Card
+            taglineBg="bg-primary-200"
+            heading="Meet Folks that are Redefining the Initiative"


Suggested change

heading="Meet Folks that are Redefining the Initiative"

heading="Meet Folks Redefining the Initiative"

quetzalliwrites · 2023-03-09T02:30:22Z

pages/community/index.js

+          <Card
+            taglineBg="bg-primary-200"
+            heading="Meet Folks that are Redefining the Initiative"
+            description="Learn how to become a technical steering committee member and see our current tsc members."


Suggested change

description="Learn how to become a technical steering committee member and see our current tsc members."

description="Learn how to become a Technical Steering Committee (TSC) member and see our current members."

quetzalliwrites

review done! ✅ ✨✨✨💪🏿

quetzalliwrites · 2023-03-09T02:33:33Z

Wow, I love this iteration; these updates make this page extremely informative!!!

THANK YOU, @AceTheCreator 💪🏿✨✨✨

AceTheCreator · 2023-03-14T09:44:58Z

Added suggested changes cc @derberg @akshatnema @alequetzalli

AceTheCreator · 2023-03-15T17:07:52Z

/rtm

akshatnema · 2023-03-15T19:03:47Z

@AceTheCreator You need to wait for @alequetzalli to approve the changes 😄

AceTheCreator · 2023-03-15T19:36:15Z

@AceTheCreator You need to wait for @alequetzalli to approve the changes 😄

While you're right, I don't think she has any changes to suggest again 🙂

We need to speed up merging the community branch, so this pr is rtm

quetzalliwrites · 2023-03-15T22:28:01Z

/rtm

quetzalliwrites · 2023-03-15T22:29:11Z

"We need to speed up merging... "

welcome to oss 😄

AceTheCreator added 9 commits February 28, 2023 10:14

Merge branch 'master' of https://github.com/AceTheCreator/website int…

f93b807

…o community

Merge branch 'community' of https://github.com/AceTheCreator/website …

df693ea

…into community

Merge branch 'community' of https://github.com/AceTheCreator/website …

fc3d0a2

…into community

replaced image format

7b1e9a9

removed unused component

fe9d71c

moved ambassadors content to a new file

60e8072

created components for community section

4299cdc

changes implemented

1ce274a

.

7fc54cb

AceTheCreator requested review from fmvilas, derberg, mcturco, akshatnema, magicmatatjahu and asyncapi-bot-eve as code owners March 6, 2023 21:23

akshatnema reviewed Mar 7, 2023

View reviewed changes

akshatnema requested changes Mar 7, 2023

View reviewed changes

akshatnema reviewed Mar 7, 2023

View reviewed changes

added shadow to cards and bd color

b6f1376

quetzalliwrites reviewed Mar 9, 2023

View reviewed changes

pages/community/index.js Outdated Show resolved Hide resolved

quetzalliwrites reviewed Mar 9, 2023

View reviewed changes

quetzalliwrites requested changes Mar 9, 2023

View reviewed changes

added suggested changes

e9be2f5

.

06dc3bb

derberg approved these changes Mar 14, 2023

View reviewed changes

akshatnema approved these changes Mar 15, 2023

View reviewed changes

asyncapi-bot added the ready-to-merge label Mar 15, 2023

quetzalliwrites approved these changes Mar 15, 2023

View reviewed changes

quetzalliwrites merged commit f0e7afb into asyncapi:community Mar 15, 2023

AceTheCreator deleted the minorUpdate branch March 16, 2023 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: more enhancement to UI #1402

fix: more enhancement to UI #1402

AceTheCreator commented Mar 6, 2023

netlify bot commented Mar 6, 2023 •

edited

Loading

akshatnema Mar 7, 2023

AceTheCreator Mar 8, 2023

akshatnema Mar 8, 2023 •

edited

Loading

AceTheCreator Mar 8, 2023

akshatnema left a comment

akshatnema left a comment

AceTheCreator commented Mar 8, 2023

AceTheCreator commented Mar 8, 2023

derberg commented Mar 8, 2023

quetzalliwrites Mar 9, 2023 •

edited

Loading

quetzalliwrites Mar 9, 2023

quetzalliwrites Mar 9, 2023

quetzalliwrites Mar 9, 2023

quetzalliwrites Mar 9, 2023

quetzalliwrites Mar 9, 2023

quetzalliwrites Mar 9, 2023

quetzalliwrites left a comment

quetzalliwrites commented Mar 9, 2023

AceTheCreator commented Mar 14, 2023

AceTheCreator commented Mar 15, 2023

akshatnema commented Mar 15, 2023

AceTheCreator commented Mar 15, 2023 •

edited

Loading

quetzalliwrites commented Mar 15, 2023

quetzalliwrites commented Mar 15, 2023

		description="Discover over 100s of interesting issues, suitable for both new
		contributors and existing contributors."

	heading="Meet Folks that are Redefining the Initiative"
	heading="Meet Folks Redefining the Initiative"

	description="Learn how to become a technical steering committee member and see our current tsc members."
	description="Learn how to become a Technical Steering Committee (TSC) member and see our current members."

fix: more enhancement to UI #1402

fix: more enhancement to UI #1402

Conversation

AceTheCreator commented Mar 6, 2023

netlify bot commented Mar 6, 2023 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshatnema Mar 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshatnema left a comment

Choose a reason for hiding this comment

akshatnema left a comment

Choose a reason for hiding this comment

AceTheCreator commented Mar 8, 2023

AceTheCreator commented Mar 8, 2023

derberg commented Mar 8, 2023

quetzalliwrites Mar 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quetzalliwrites left a comment

Choose a reason for hiding this comment

quetzalliwrites commented Mar 9, 2023

AceTheCreator commented Mar 14, 2023

AceTheCreator commented Mar 15, 2023

akshatnema commented Mar 15, 2023

AceTheCreator commented Mar 15, 2023 • edited Loading

quetzalliwrites commented Mar 15, 2023

quetzalliwrites commented Mar 15, 2023

netlify bot commented Mar 6, 2023 •

edited

Loading

akshatnema Mar 8, 2023 •

edited

Loading

quetzalliwrites Mar 9, 2023 •

edited

Loading

AceTheCreator commented Mar 15, 2023 •

edited

Loading