-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ScrollToTopButton #1396
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1396--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Not like this exactly, you will have an arrow up in the dark-gray or black color, but no borders around it in dark black color. |
@akshatnema is this a good choice for scroll to top button? |
I have pushed the tentative changes for now ,so that you can see the changes in netlify deploy |
You need to do some more changes related to image, as it looks large in the desktop view. Please make it slightly smaller and then make a circular block element with white background and provide box-shadow to it, so that it looks like a button. |
ok ,got the idea of all the changes I need to do. Will get back to you soon. |
@akshatnema I have made the changes,PTAL. I have one approach for this that we can make the middle arrow as white and have a rounded border around it in blue color (the same color which is present in footer) or a little dark blue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly remove the previous arrow image and add the current arrow image in SVG format. It is not a vector image right now.
Also, add the property scroll-behavior
to the HTML tag inside global.css and provide it's value as smooth
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sambhavgupta0705 , i would highly recommend you to make this a little bit smaller. For mobile devices the button looks huge. Which might be having a bad effect on the overall UI/UX.
And also since majority of the website uses #1B1031
as their color theme, i would recommend using the same color in the svg's arrow too.
Hey @akshatnema PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added.
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
/rtm |
Description
Related issue(s)
Fixes #1350