Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ScrollToTopButton #1396

Merged
merged 14 commits into from
Apr 5, 2023
Merged

feat: added ScrollToTopButton #1396

merged 14 commits into from
Apr 5, 2023

Conversation

sambhavgupta0705
Copy link
Member

Description

  • Added a scroll to top button for all pages of website
    image

Related issue(s)

Fixes #1350

@netlify
Copy link

netlify bot commented Mar 4, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5d90f14
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/642dd6b7f78d04000898d361
😎 Deploy Preview https://deploy-preview-1396--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟠 Accessibility 88
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1396--asyncapi-website.netlify.app/

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please make this button with white background, some shadows and an arrow white in color. That color scheme will match more with the website theme.

@sambhavgupta0705
Copy link
Member Author

image
@akshatnema is this a good option for scroll to top button?

@akshatnema
Copy link
Member

@akshatnema is this a good option for scroll to top button?

Not like this exactly, you will have an arrow up in the dark-gray or black color, but no borders around it in dark black color.

@sambhavgupta0705
Copy link
Member Author

@akshatnema is this a good choice for scroll to top button?
image

@sambhavgupta0705
Copy link
Member Author

I have pushed the tentative changes for now ,so that you can see the changes in netlify deploy

@akshatnema
Copy link
Member

@akshatnema is this a good choice for scroll to top button?

You need to do some more changes related to image, as it looks large in the desktop view. Please make it slightly smaller and then make a circular block element with white background and provide box-shadow to it, so that it looks like a button.

@sambhavgupta0705
Copy link
Member Author

@akshatnema is this a good choice for scroll to top button?

You need to do some more changes related to image, as it looks large in the desktop view. Please make it slightly smaller and then make a circular block element with white background and provide box-shadow to it, so that it looks like a button.

ok ,got the idea of all the changes I need to do. Will get back to you soon.

@sambhavgupta0705
Copy link
Member Author

sambhavgupta0705 commented Mar 9, 2023

@akshatnema I have made the changes,PTAL.

I have one approach for this that we can make the middle arrow as white and have a rounded border around it in blue color (the same color which is present in footer) or a little dark blue.

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly remove the previous arrow image and add the current arrow image in SVG format. It is not a vector image right now.

Also, add the property scroll-behavior to the HTML tag inside global.css and provide it's value as smooth.

Copy link

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sambhavgupta0705 , i would highly recommend you to make this a little bit smaller. For mobile devices the button looks huge. Which might be having a bad effect on the overall UI/UX.

And also since majority of the website uses #1B1031 as their color theme, i would recommend using the same color in the svg's arrow too.

image

@sambhavgupta0705
Copy link
Member Author

Hey @akshatnema PTAL

@akshatnema
Copy link
Member

Screenshot_2023-04-05-16-55-31-74.jpg

There is a small overlap between the add-this component and button. Kindly make the component position such that they don't overlap on any screen.

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added.

components/buttons/ScrollButton.js Outdated Show resolved Hide resolved
@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 1805bff into asyncapi:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll back to top button
4 participants