Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blog): new post about asyncapi status after 2022 #1360

Merged
merged 15 commits into from
Feb 28, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Feb 21, 2023

don't worry about all the other changes, most important is the article

  • other article changes I did was to cleanup featured flag. We had it in so many articles that it no longer made sense to use
  • images for my article are of course small and webp

@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 7b6889d
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63fdd576c80e8c0008e5a3e0
😎 Deploy Preview https://deploy-preview-1360--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 21, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 31
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1360--asyncapi-website.netlify.app/

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I love it. That said, I'd love it even more if I had some charts next to each data table. It would help me understand much better.

pages/blog/2022-summary.md Outdated Show resolved Hide resolved
@derberg
Copy link
Member Author

derberg commented Feb 22, 2023

@fmvilas I replaced all tables with charts to be consistent across entire article

@fmvilas @alequetzalli ready for final approval

@quetzalliwrites
Copy link
Member

oh wait.. this is a NEW blog post, right?? I don't think I see any actual review done before, sorry I think I got messed up on this one.. lemme review it then 😄✌🏽

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done for real now 😂

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my suggestions. I have no other suggestions than the ones Ale already added so I won't approve yet but consider it approved from my side once you address all her suggestions.

@fmvilas
Copy link
Member

fmvilas commented Feb 23, 2023

BTW, is it just me or most of the images look really bad on a laptop-size screen? They look blurry for me. Not all of them though. Maybe you have to export them with a bit higher quality.

derberg and others added 2 commits February 23, 2023 12:31
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Copy link
Member Author

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli I knew your initial approval was too beautiful to be true 😆

@fmvilas you are totally right about images, all refreshed, also I improved a lot the github related images

@quetzalliwrites
Copy link
Member

@alequetzalli I knew your initial approval was too beautiful to be true 😆

bahahahahahahaha poor lukasz 😂😂😂😂😂

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🚢 ✨🚢 ✨🚢 ✨

@derberg
Copy link
Member Author

derberg commented Feb 27, 2023

@fmvilas since you requested changes I cannot merge without your explicit approval.

@derberg
Copy link
Member Author

derberg commented Feb 28, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c16c0bb into asyncapi:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants