-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blog): new post about asyncapi status after 2022 #1360
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1360--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I love it. That said, I'd love it even more if I had some charts next to each data table. It would help me understand much better.
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
oh wait.. this is a NEW blog post, right?? I don't think I see any actual review done before, sorry I think I got messed up on this one.. lemme review it then 😄✌🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done for real now 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my suggestions. I have no other suggestions than the ones Ale already added so I won't approve yet but consider it approved from my side once you address all her suggestions.
BTW, is it just me or most of the images look really bad on a laptop-size screen? They look blurry for me. Not all of them though. Maybe you have to export them with a bit higher quality. |
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli I knew your initial approval was too beautiful to be true 😆
@fmvilas you are totally right about images, all refreshed, also I improved a lot the github related images
bahahahahahahaha poor lukasz 😂😂😂😂😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨🚢 ✨🚢 ✨🚢 ✨
@fmvilas since you |
/rtm |
don't worry about all the other changes, most important is the article
featured
flag. We had it in so many articles that it no longer made sense to use