Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor fixes #1315

Merged
merged 6 commits into from
Feb 14, 2023
Merged

fix: minor fixes #1315

merged 6 commits into from
Feb 14, 2023

Conversation

AceTheCreator
Copy link
Member

@AceTheCreator AceTheCreator commented Feb 8, 2023

  • Fixed missing images on the ambassador page
  • Fixed the broken ambassador page link
  • Linked contributors page to contributors' discussion
  • Replaced meetings on the community homepage with actual meeting data

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 120bd97
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63e4310f83784d0008476577
😎 Deploy Preview https://deploy-preview-1315--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AceTheCreator
Copy link
Member Author

cc @derberg @akshatnema @alequetzalli

@quetzalliwrites
Copy link
Member

I don't think I even notice the differences 😆

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AceTheCreator, the events section filter is not working correctly according to the date and time. Can you please look into this?

image

@AceTheCreator
Copy link
Member Author

Hey @AceTheCreator, the events section filter is not working correctly according to the date and time. Can you please look into this?

image

So, the logic behind it is actually correct. Because I did some modifications to the meeting generation script, which also changed the date format in the meetings

@akshatnema
Copy link
Member

So, the logic behind it is actually correct. Because I did some modifications to the meeting generation script, which also changed the date format in the meetings

So, the logic of the update meeting generation script is on main branch? or it is in this PR?

@AceTheCreator
Copy link
Member Author

So, the logic behind it is actually correct. Because I did some modifications to the meeting generation script, which also changed the date format in the meetings

So, the logic of the update meeting generation script is on main branch? or it is in this PR?

It's already in the community branch

@akshatnema
Copy link
Member

It's already in the community branch

Then why we aren't getting the logic correct in the Preview URL? It's also not working in my local system too. Have you tested it perfectly?

@AceTheCreator
Copy link
Member Author

It's already in the community branch

Then why we aren't getting the logic correct in the Preview URL? It's also not working in my local system too. Have you tested it perfectly?

It's a script triggered by GH action and can only run once it's merged into master. and yes, I tested it :)

@akshatnema
Copy link
Member

It's a script triggered by GH action and can only run once it's merged into master. and yes, I tested it :)

Sorry, I think you didn't get my question 😅. I'm not talking about the meeting generation script. I'm talking about the logic of EventsFilters. The date of the Event is 7th February, then why it is showing inside Upcoming Section? It should be inside Recorded section.

@AceTheCreator
Copy link
Member Author

It's a script triggered by GH action and can only run once it's merged into master. and yes, I tested it :)

Sorry, I think you didn't get my question 😅. I'm not talking about the meeting generation script. I'm talking about the logic of EventsFilters. The date of the Event is 7th February, then why it is showing inside Upcoming Section? It should be inside Recorded section.

I get your question @akshatnema. The reason why it's like that is cuz of the date format in the current generated meeting. In the meeting filter, the format is not compatible with the logic I'm using that's why you're seeing the meeting appear on every list. Once the new meeting generation script is triggered, that will be fixed

@AceTheCreator
Copy link
Member Author

AceTheCreator commented Feb 14, 2023

It's a script triggered by GH action and can only run once it's merged into master. and yes, I tested it :)

Sorry, I think you didn't get my question 😅. I'm not talking about the meeting generation script. I'm talking about the logic of EventsFilters. The date of the Event is 7th February, then why it is showing inside Upcoming Section? It should be inside Recorded section.

I get your question @akshatnema. The reason why it's like that is cuz of the date format in the current generated meeting. In the meeting filter, the format is not compatible with the logic I'm using that's why you're seeing the meeting appear on every list. Once the new meeting generation script is triggered, that will be fixed

This is the new date format I'm using 2021-08-25T23:00:00.000Z instead of Wed, 25 Aug 2021 23:00:00 GMT

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect then! Approving this PR ✔️

@AceTheCreator
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit fb6ffac into asyncapi:community Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants