Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify example #1306

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix: modify example #1306

merged 2 commits into from
Feb 10, 2023

Conversation

Barbanio
Copy link
Contributor

@Barbanio Barbanio commented Feb 7, 2023

The Event-driven example may lead to confusion, so I propose another example that I think may be clearer.

@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eb33a58
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63e5b9b77af34a000891c03a
😎 Deploy Preview https://deploy-preview-1306--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Barbanio Barbanio changed the title Modified example fix: modify example Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1306--asyncapi-website.netlify.app/

@quetzalliwrites
Copy link
Member

i think this looked good with the original text, but this works too 😄✌🏽

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit aa73089 into asyncapi:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants