fix: addition of Prev/Next buttons in build time #1273
Conversation
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
akshatnema
requested review from
fmvilas,
derberg,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1273--asyncapi-website.netlify.app/ |
|
@derberg @alequetzalli @magicmatatjahu Kindly review this PR and do point out the errors you find out in the implementation. In case, you don't understand any part of implementation, feel free to ask it. |
|
hmm this feels a little weird.. what do you think @akshatnema? 🙃
|
Yeah, this feels little weird for everyone, but if we want to show the rootElement titles too, this one has rootElement title and page title same. And I don't want to hardcode the prev/next buttons specially for this case. |
|
yeah i hear you, i guess it will be ok 👍 |
| @@ -16,8 +23,23 @@ const postDirectories = [ | |||
| [`${basePath}/jobs`, '/jobs'], | |||
| ] | |||
|
|
|||
| const addItem = (details) => { | |||
There was a problem hiding this comment.
this could be a switch case, but tbh, I don't really care 😄
|
/rtm |
Description
This PR rewrites the logic of automation of Prev and UpNext buttons of docs in scripts folder. Hence, the entire implementation of the buttons are written and executed on build time, rather on run time, thus improving the efficiency of the website. Also, to inform that the structure of the posts.json has been changed from array of all posts to the JSON object having key-value pairs of
docs,blog,about,jobsanddocsTree.Related issue(s)
Extends #1188