feat: add filtered domains in filter in tools dashboard #1272
Conversation
janvi01
requested review from
fmvilas,
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
janvi01
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1272--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Hey @janvi01, thanks for contributing to the issue. My suggestion is that if we are mentioning the tags selected in the filter, let's not just make it only UI. We should make it some way useful. Add a cross (in icon) button beside each tag so as to remove the filter without opening the dropdown for the field. Also, I find that these values look slightly similar to the fields given inside the Filter Dropdown. So, Can you please make it like having light gray border and on hover, slightly dark to make them different from others.
It will be nice if you can add a feature that when some tags are selected in the filter, this filter header shows the number of tags selected like "3 options selected", and none of them are selected, "Select Languages..." are there. I hope you will understand. If not, you can ask me freely.
|
Hey, @akshatnema Thanks for the amazing improvement suggestions. I will update the PR soon. |
|
I have changed the tags ui as per the suggestion, added the functionality to remove the filter and labels in the dropdown when a certain number of tags are selected. Also when 1 option is selected, it says 'option' else 'options'. |
|
/rtm |
Description
The PR adds the filtered domain below the dropdown in the tool's dashboard. Below is the screenshot that depicts the implemenatation.
Screenshot -
Related issue(s)
Fixes #1270