Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting order in tools dashboard #1232

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

Ankitchaudharyy
Copy link
Contributor

Description
This PR sorts the tools in alphabetical order in tools dashboard.
Sorting is done in after combining tools-manual.json and tools-automated.json in combine-tools.js

Related issue(s)
Fixes #1231

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 872c924
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63cab781f68486000ae3a50e
😎 Deploy Preview https://deploy-preview-1232--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ankitchaudharyy Ankitchaudharyy changed the title fix: sorting order in toola dashboard #1231 fix: sorting order in tools dashboard Jan 19, 2023
@github-actions
Copy link

github-actions bot commented Jan 19, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 38
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1232--asyncapi-website.netlify.app/

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔️, but I will wait until #1226 gets merged to the master.

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit c5c2b7a into asyncapi:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview the tools in alphabetical sorted manner
3 participants