chore: improve json schema for .asyncapi-tool
#1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
requested review from
fmvilas,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1161--asyncapi-website.netlify.app/ |
akshatnema
previously approved these changes
Dec 15, 2022
magicmatatjahu
requested changes
Dec 16, 2022
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
magicmatatjahu
approved these changes
Dec 20, 2022
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.asyncapi-toolswith this PR I'm just adding as many details as possible so we can push it to schema store. As a followup we can think of a bit automated way to update this JSON Schema, as at the moment
enuminformation is duplicated there manually.